Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-926289 restrict urllib3 pin to only affect Python < 3.10 #1799

Merged
merged 6 commits into from
Nov 16, 2023
Merged

SNOW-926289 restrict urllib3 pin to only affect Python < 3.10 #1799

merged 6 commits into from
Nov 16, 2023

Conversation

sfc-gh-mkeller
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller commented Nov 8, 2023 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-926289: Why is urllib3 both vendored and marked as a dependency? #1743

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    This PR restricts our urllib3 version pin to Python versions <3.10

@sfc-gh-mkeller sfc-gh-mkeller marked this pull request as ready for review November 15, 2023 17:14
@sfc-gh-mkeller sfc-gh-mkeller merged commit 7b4b708 into main Nov 16, 2023
73 of 75 checks passed
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/SNOW-926289-widen_urllib3_pin branch November 16, 2023 22:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-926289: Why is urllib3 both vendored and marked as a dependency?
3 participants
@sfc-gh-mkeller @sfc-gh-sfan @sfc-gh-aling