SNOW-1662105, SNOW-1662657: Support by, left_by, right_by for pd.merge_asof
#2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naren Krishna <naren.krishna@snowflake.com>
sfc-gh-nkrishna
requested review from
sfc-gh-lspiegelberg and
sfc-gh-rdurrani
sfc-gh-nkrishna
added
NO-CHANGELOG-UPDATES
sfc-gh-nkrishna
requested review from
sfc-gh-yzou
and removed request for
sfc-gh-lspiegelberg
|
@sfc-gh-nkrishna I created a JIRA ticket for this refactor work from you, could you please or do you mind I linking it to this PR? https://snowflakecomputing.atlassian.net/browse/SNOW-1662105 Thanks |
sfc-gh-nkrishna
changed the title
sfc-gh-azhan
requested changes
Sep 12, 2024
|
Perhaps @sfc-gh-nkumar can take a quick look? |
sfc-gh-yzou
reviewed
Sep 12, 2024
Signed-off-by: Naren Krishna <naren.krishna@snowflake.com>
sfc-gh-yzou
reviewed
Sep 12, 2024
sfc-gh-nkrishna
changed the title
by, left_by, right_by for pd.merge_asof
sfc-gh-nkrishna
changed the title
by, left_by, right_by for pd.merge_asofby, left_by, right_by for pd.merge_asof
Signed-off-by: Naren Krishna <naren.krishna@snowflake.com>
sfc-gh-nkrishna
commented
Sep 12, 2024
sfc-gh-nkrishna
removed
NO-CHANGELOG-UPDATES
Signed-off-by: Naren Krishna <naren.krishna@snowflake.com>
Signed-off-by: Naren Krishna <naren.krishna@snowflake.com>
Signed-off-by: Naren Krishna <naren.krishna@snowflake.com>
sfc-gh-azhan
approved these changes
Sep 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-1662105, SNOW-1662657
This PR refactors
join_utils.pyto makeleft_onandright_onoptional arguments, as they are not required for "cross" or "asof" joins. It also supportby,left_by,right_byforpd.merge_asof.