SNOW-1707419: Improve error message for unknown timezone in tz_convert and tz_localize

[sfc-gh-helmeleegy]

1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

   Fixes SNOW-1707419

2. Fill out the following pre-review checklist:

   • I am adding a new automated test(s) to verify correctness of my new code
     • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
   • I am adding new logging messages
   • I am adding a new telemetry message
   • I am adding new credentials
   • I am adding a new dependency
   • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

3. Please describe how your code solves the related issue.

   Improve error message for unknown timezone in tz_convert and tz_localize.

[sfc-gh-lmukhopadhyay]

LGTM! I just had one suggestion for checking the error message in the negative tests

[sfc-gh-azhan]

why not just support it?

[sfc-gh-jjiao]

I am not sure why we are checking the input string against pytz.all_timezones.

By comparison, native pandas does support timezone format like UTC:+09:00 etc

[sfc-gh-helmeleegy]

I am not sure why we are checking the input string against pytz.all_timezones.

By comparison, native pandas does support timezone format like UTC:+09:00 etc

It's mainly to stay consistent with Snowflake's restrictions on input timezones. Please refer to the previous thread.

[sfc-gh-jjiao]

I am not sure why we are checking the input string against pytz.all_timezones.
By comparison, native pandas does support timezone format like UTC:+09:00 etc

It's mainly to stay consistent with Snowflake's restrictions on input timezones. Please refer to the previous thread.

Sounds good!

This PR is only dealing with error message?

            ErrorMessage.not_implemented(
                f"Snowpark pandas 'tz_convert' method doesn't support 'tz={tz}'"
            )

Could we update this PR directly to raise NotImplementedError or you are going to merge this first and then create a new PR to do that?

[sfc-gh-helmeleegy]

Sounds good!

This PR is only dealing with error message?

            ErrorMessage.not_implemented(
                f"Snowpark pandas 'tz_convert' method doesn't support 'tz={tz}'"
            )

Could we update this PR directly to raise NotImplementedError or you are going to merge this first and then create a new PR to do that?

This PR already raises NotImplementedError.

[sfc-gh-helmeleegy]

why not just support it?

Addressed in other threads.