Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1727330, SNOW-1727332, SNOW-1727334, SNOW-1727335: Add support for DataFrameGroupBy/SeriesGroupBy.bfill/ffill #2449

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

sfc-gh-helmeleegy
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy commented Oct 14, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1727330, SNOW-1727332, SNOW-1727334, SNOW-1727335

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Add support for DataFrameGroupBy/SeriesGroupBy.bfill/ffill.

…or DataFrameGroupBy/SeriesGroupBy.bfill/ffill
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment around fixing the CHANGELOG

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question: did we already support DataFrameGroupBy.fillna with both method="ffill" and method="bfill", but we just didn't expose those methods through DataFrameGroupBy.bfill and DataFrameGroupBy.ffill?

@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit eeae4d5 into main Oct 17, 2024
37 of 38 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-1727330 branch October 17, 2024 20:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
@sfc-gh-helmeleegy
Copy link
Contributor Author

LGTM, just one question: did we already support DataFrameGroupBy.fillna with both method="ffill" and method="bfill", but we just didn't expose those methods through DataFrameGroupBy.bfill and DataFrameGroupBy.ffill?

Yes, DataFrameGroupBy.fillna was already supported.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants