-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SNOW-1748174]: Add support for size
in groupby.agg
#2474
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to update the changelog + supported doc
src/snowflake/snowpark/modin/plugin/extensions/groupby_overrides.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/extensions/groupby_overrides.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/extensions/groupby_overrides.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/_internal/aggregation_utils.py
Outdated
Show resolved
Hide resolved
} | ||
) | ||
|
||
pandas_df = snowpark_pandas_df.to_pandas() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you swap the native + snowpandas construction to avoid an extra query?
blocked by: #2475 |
9a4f455
to
0ca007f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one thing: can you add a test case for SeriesGroupBy.agg
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, Rehan!
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1748174
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add support for
size
ingroupby.agg
.