Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1748174]: Add support for size in groupby.agg #2474

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[SNOW-1748174]: Add support for size in groupby.agg #2474

wants to merge 9 commits into from

Conversation

sfc-gh-rdurrani
Copy link
Contributor

@sfc-gh-rdurrani sfc-gh-rdurrani commented Oct 17, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1748174

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

Add support for size in groupby.agg .

@sfc-gh-rdurrani sfc-gh-rdurrani requested a review from a team as a code owner October 17, 2024 22:59
sfc-gh-joshi
sfc-gh-joshi requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to update the changelog + supported doc

src/snowflake/snowpark/modin/plugin/extensions/groupby_overrides.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/extensions/groupby_overrides.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/extensions/groupby_overrides.py Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/_internal/aggregation_utils.py Outdated Show resolved Hide resolved
tests/integ/modin/groupby/test_groupby_size.py Outdated
}
)

pandas_df = snowpark_pandas_df.to_pandas()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you swap the native + snowpandas construction to avoid an extra query?

tests/integ/modin/groupby/test_groupby_size.py Outdated Show resolved Hide resolved
@sfc-gh-rdurrani
Copy link
Contributor Author

blocked by: #2475

@sfc-gh-rdurrani sfc-gh-rdurrani marked this pull request as draft October 18, 2024 00:30
@sfc-gh-rdurrani sfc-gh-rdurrani marked this pull request as ready for review October 22, 2024 21:10
sfc-gh-joshi
sfc-gh-joshi approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one thing: can you add a test case for SeriesGroupBy.agg as well?

sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Rehan!

@sfc-gh-rdurrani sfc-gh-rdurrani enabled auto-merge (squash) October 22, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-joshi sfc-gh-joshi sfc-gh-joshi approved these changes

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-jkew sfc-gh-jkew Awaiting requested review from sfc-gh-jkew sfc-gh-jkew is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-rdurrani @sfc-gh-joshi @sfc-gh-helmeleegy