SNOW-862622 Add support for timestamp variations #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-azhan
force-pushed
the
azhan-timestmap-tz-862622
branch
3 times, most recently
from
025b930
to
53dcd6a
Compare
Codecov Report
@@ Coverage Diff @@
## main #943 +/- ##
=======================================
Coverage 98.46% 98.47%
=======================================
Files 51 51
Lines 9079 9122 +43
Branches 1626 1642 +16
=======================================
+ Hits 8940 8983 +43
Misses 55 55
Partials 84 84
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-azhan
force-pushed
the
azhan-timestmap-tz-862622
branch
from
53dcd6a
to
1a68d81
Compare
sfc-gh-azhan
changed the title
sfc-gh-azhan
force-pushed
the
azhan-timestmap-tz-862622
branch
from
1a68d81
to
ccd6bdc
Compare
sfc-gh-azhan
requested review from
sfc-gh-sfan,
sfc-gh-vnayak,
sfc-gh-jdu,
sfc-gh-yixie,
sfc-gh-yzou and
sfc-gh-sshankar
sfc-gh-sfan
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Looks good. You might want to test in stored proc (job) and see if it works.
sfc-gh-yzou
reviewed
Jul 18, 2023
running https://ci-dev-142.int.snowflakecomputing.com/job/PythonStoredProcBuildPrecommitTest/464/ |
sfc-gh-jdu
approved these changes
Jul 18, 2023
sfc-gh-azhan
commented
Jul 18, 2023
| @@ -285,6 +294,10 @@ def infer_type(obj: Any) -> DataType: | |||
| if datatype is DecimalType: | |||
| # the precision and scale of `obj` may be different from row to row. | |||
| return DecimalType(38, 18) | |||
| elif datatype is TimestampType and obj.tzinfo is not None: | |||
There was a problem hiding this comment.
@sfc-gh-yzou ^^^
sfc-gh-azhan
force-pushed
the
azhan-timestmap-tz-862622
branch
2 times, most recently
from
530c10e
to
9d43416
Compare
sfc-gh-azhan
force-pushed
the
azhan-timestmap-tz-862622
branch
from
e4b5f9a
to
63a9a2b
Compare
sfc-gh-azhan
force-pushed
the
azhan-timestmap-tz-862622
branch
from
63a9a2b
to
5eb0d94
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
SNOW-862622 Add support for timestamp variations
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
This PR adds support for Snowflake timestamp variations, e.g., TIMESTAMP_NTZ, TIMESTAMP_TZ, TIMESTAMP_LTZ. Today Snowpark Python only supports Timestamp alias for Timestamp types and the underlying type is controlled by TIMESTAMP_TYPE_MAPPING. This PR allows user to specify which variation of TIMESTAMP type to use by adding a
TimestampTypeattributetz.