Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pytest timeout package to FIPS environment #952

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Add pytest timeout package to FIPS environment #952

merged 3 commits into from
Jul 18, 2023

Conversation

sfc-gh-vnayak
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-vnayak sfc-gh-vnayak added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 18, 2023
@sfc-gh-vnayak sfc-gh-vnayak self-assigned this Jul 18, 2023
@sfc-gh-vnayak sfc-gh-vnayak changed the title Add timeout package to FIPS environment Add pytest timeout package to FIPS environment Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #952 (8442d4e) into main (36e0577) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
+ Coverage   98.58%   98.59%   +0.01%     
==========================================
  Files          50       50              
  Lines        8962     8962              
  Branches     1598     1598              
==========================================
+ Hits         8835     8836       +1     
  Misses         49       49              
+ Partials       78       77       -1

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-vnayak sfc-gh-vnayak marked this pull request as ready for review July 18, 2023 23:16
@sfc-gh-vnayak sfc-gh-vnayak requested a review from a team as a code owner July 18, 2023 23:16
@sfc-gh-vnayak sfc-gh-vnayak merged commit 3578ded into main Jul 18, 2023
41 checks passed
@sfc-gh-vnayak sfc-gh-vnayak deleted the vnayak-add-timeout-package-to-fips-env branch July 18, 2023 23:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu was automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg Awaiting requested review from sfc-gh-lspiegelberg sfc-gh-lspiegelberg was automatically assigned from snowflakedb/snowpark-python-api

Assignees

@sfc-gh-vnayak sfc-gh-vnayak

Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-vnayak @sfc-gh-aalam