Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-853049 Add write_pandas test to a different schema #958

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

sfc-gh-sfan
Copy link
Collaborator

Description

This enables testing writing pandas DF to a different schema for both client and stored proc.

Testing

integ

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-853049

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    This enables testing writing pandas DF to a different schema for both client and stored proc.

Description

This enables testing writing pandas DF to a different schema for both
client and stored proc.

Testing

integ
@sfc-gh-sfan
Copy link
Collaborator Author

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #958 (1b3511e) into main (edd7f29) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   98.46%   98.47%           
=======================================
  Files          51       51           
  Lines        9079     9122   +43     
  Branches     1626     1642   +16     
=======================================
+ Hits         8940     8983   +43     
  Misses         55       55           
  Partials       84       84           

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-sfan sfc-gh-sfan added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 20, 2023
@sfc-gh-sfan sfc-gh-sfan merged commit 8f557fa into main Jul 20, 2023
41 of 42 checks passed
@sfc-gh-sfan sfc-gh-sfan deleted the shixuan_write_pandas_test branch July 20, 2023 19:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants