-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase pytest timeout to 1200 seconds #969
Conversation
@@ -131,7 +131,7 @@ markers = | |||
doctest: doctest tests | |||
# Other markers | |||
timeout: tests that need a timeout time | |||
addopts = --doctest-modules --timeout=300 | |||
addopts = --doctest-modules --timeout=1200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of the timeout is to detect infinitely stalling tests; having a very wide timeout will help prevent non-stalling tests from failing when many test runs are occurring simultaneously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is our action item to actually fix this?
I'm not sure if pytest-timeout gives each parametrized test same amount of time to finish but only one of the several tests ran overtime. The timeout here was added recently so I didn't put too much time investigating. If this fails again, I'll create a JIRA and investigate. |
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.