Increase pytest timeout to 1200 seconds #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-vnayak
commented
Jul 24, 2023
| @@ -131,7 +131,7 @@ markers = | |||
| doctest: doctest tests | |||
| # Other markers | |||
| timeout: tests that need a timeout time | |||
| addopts = --doctest-modules --timeout=300 | |||
| addopts = --doctest-modules --timeout=1200 | |||
There was a problem hiding this comment.
The purpose of the timeout is to detect infinitely stalling tests; having a very wide timeout will help prevent non-stalling tests from failing when many test runs are occurring simultaneously.
sfc-gh-vnayak
added
NO-CHANGELOG-UPDATES
sfc-gh-aalam
approved these changes
Jul 24, 2023
sfc-gh-sfan
reviewed
Jul 24, 2023
I'm not sure if pytest-timeout gives each parametrized test same amount of time to finish but only one of the several tests ran overtime. The timeout here was added recently so I didn't put too much time investigating. If this fails again, I'll create a JIRA and investigate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.