Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update session.py #971

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update session.py #971

wants to merge 1 commit into from

Conversation

sfc-gh-mkeller
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    I have no Jira for this.

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    I got the following warning locally:

    /Users/mkeller/snowflakedb/snowapi-python/venv/lib/python3.8/site-packages/snowflake/snowpark/session.py:1891: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
     _logger.warn(
    

    I just quickly wanted to fix this warning

@sfc-gh-mkeller sfc-gh-mkeller requested a review from a team as a code owner July 25, 2023 17:24
@sfc-gh-mkeller sfc-gh-mkeller added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #971 (cc7dd64) into main (2aac082) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #971   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          51       51           
  Lines        9184     9184           
  Branches     1666     1666           
=======================================
  Hits         9035     9035           
  Misses         59       59           
  Partials       90       90           
Files Changed Coverage Δ
src/snowflake/snowpark/session.py 98.84% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants