Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ML precommit #972

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Fix ML precommit #972

merged 2 commits into from
Jul 26, 2023

Conversation

sfc-gh-stan
Copy link
Collaborator

@sfc-gh-stan sfc-gh-stan commented Jul 25, 2023

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Fix the ValueErrors in https://ci-dev-151.int.snowflakecomputing.com/job/TestSnowMLSnowpark/70/console by (1) allowing process to have a type hint of None and (2) favoring end_parition's return type hint over that of process.

@sfc-gh-stan sfc-gh-stan added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 25, 2023
@sfc-gh-stan sfc-gh-stan marked this pull request as ready for review July 25, 2023 20:13
@sfc-gh-stan sfc-gh-stan requested a review from a team as a code owner July 25, 2023 20:13
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #972 (f4ab87d) into main (2aac082) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   98.37%   98.35%   -0.03%     
==========================================
  Files          51       51              
  Lines        9184     9193       +9     
  Branches     1666     1668       +2     
==========================================
+ Hits         9035     9042       +7     
- Misses         59       60       +1     
- Partials       90       91       +1     
Files Changed Coverage Δ
src/snowflake/snowpark/_internal/udf_utils.py 94.60% <85.71%> (-0.42%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-stan sfc-gh-stan enabled auto-merge (squash) July 25, 2023 23:25
@sfc-gh-stan sfc-gh-stan merged commit 635e5a7 into main Jul 26, 2023
39 of 41 checks passed
@sfc-gh-stan sfc-gh-stan deleted the Fix-ML-precommit branch July 26, 2023 00:26
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants