Skip to content

Commit 16ea45e

Browse files
committed
Prevent rc images from getting tagged as latest in dockerhub (closes #282)
1 parent 5eec0fc commit 16ea45e

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.github/workflows/cd.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,3 +92,4 @@ jobs:
9292

9393
- name: Publish to DockerHub
9494
run: make container-release
95+
shell: bash

Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
# CONSTANTS
55
# -----------------------------------------------------------------------------
66

7+
SHELL = /bin/bash
78
version = `cat VERSION`
89
aws_only_version = $(version)-aws-only
910

@@ -164,12 +165,12 @@ http-down:
164165
# RELEASE
165166
# -----------------------------------------------------------------------------
166167

168+
# Make & push docker assets, don't tag as latest if there's a `-` in the version (eg. 0.1.0-rc1)
167169
container-release:
168170
@-docker login --username $(DOCKER_USERNAME) --password $(DOCKER_PASSWORD)
169171
docker push $(container_name):$(aws_only_version)
170172
docker push $(container_name):$(version)
171-
docker tag ${container_name}:${version} ${container_name}:latest
172-
docker push $(container_name):latest
173+
if ! [[ $(version) =~ "-" ]]; then docker tag ${container_name}:${version} ${container_name}:latest; docker push $(container_name):latest; fi;
173174

174175
# -----------------------------------------------------------------------------
175176
# CLEANUP

0 commit comments

Comments
 (0)