Merge pull request #69 from snyk/fix/additional-arguments-as-last-parameter

fix: add additional arguments as last parameter to snyk test command

Author: pavel-snyk

ops/deploy/test-builds.json

@@ -6,5 +6,9 @@
     {
         "projectName": "goof_windows",
         "buildDefinitionId": 10
+    },
+    {
+        "projectName": "azure-maven-multimodule-goof",
+        "buildDefinitionId": 16
     }
 ]

snykTask/src/__tests__/_test-mock-config-basic-smoke-test-docker.ts

@@ -48,7 +48,7 @@ const answers: ma.TaskLibAnswers = {
       code: 0,
       stdout: "Snyk CLI authorized!"
     },
-    "/usr/bin/snyk test --docker myImage --file=Dockerfile --someAdditionalArgs --json-file-output=report.json": {
+    "/usr/bin/snyk test --docker myImage --file=Dockerfile --json-file-output=report.json --someAdditionalArgs": {
       code: 0,
       stdout: "No issues found"
     },

snykTask/src/__tests__/_test-mock-config-basic-smoke-test.ts

@@ -50,7 +50,7 @@ const answers: ma.TaskLibAnswers = {
       code: 0,
       stdout: "No issues found"
     },
-    "/usr/bin/snyk test --someAdditionalArgs --json-file-output=report.json": {
+    "/usr/bin/snyk test --json-file-output=report.json --someAdditionalArgs": {
       code: 0,
       stdout: "No issues found"
     },

snykTask/src/__tests__/test-task.ts

@@ -38,7 +38,7 @@ test("basic smoke test - inputs are ok", () => {
   );
   expect(
     mockTestRunner.cmdlines[
-      "/usr/bin/snyk test --someAdditionalArgs --json-file-output=report.json"
+      "/usr/bin/snyk test --json-file-output=report.json --someAdditionalArgs"
     ]
   ).toBe(true);
   expect(mockTestRunner.cmdlines["/usr/bin/snyk-to-html -i report.json"]).toBe(
@@ -70,7 +70,7 @@ test("basic smoke test for container test - inputs are ok", () => {
   );
   expect(
     mockTestRunner.cmdlines[
-      "/usr/bin/snyk test --docker myImage --file=Dockerfile --someAdditionalArgs --json-file-output=report.json"
+      "/usr/bin/snyk test --docker myImage --file=Dockerfile --json-file-output=report.json --someAdditionalArgs"
     ]
   ).toBe(true);
   expect(mockTestRunner.cmdlines["/usr/bin/snyk-to-html -i report.json"]).toBe(

snykTask/src/index.ts

@@ -183,8 +183,8 @@ async function runSnykTest(
     .argIf(taskArgs.dockerImageName, `--docker`)
     .argIf(taskArgs.dockerImageName, `${taskArgs.dockerImageName}`)
     .argIf(fileArg, `--file=${fileArg}`)
-    .line(taskArgs.additionalArguments)
-    .arg(`--json-file-output=${jsonReportOutputPath}`);
+    .arg(`--json-file-output=${jsonReportOutputPath}`)
+    .line(taskArgs.additionalArguments);
 
   const options = getOptionsToExecuteSnykCLICommand(
     taskArgs,