fix: more linter warnings

Author: acke

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/BaseBranchDialog.java

@@ -25,7 +25,7 @@ public class BaseBranchDialog {
 	public BaseBranchDialog() {
 	}
 
-	public void open(Display display, Path projectPath, String[] localBranches) {
+	public void open(Display display, Path projectPath, String... localBranches) {
 		Shell shell = new Shell(display, SWT.APPLICATION_MODAL | SWT.DIALOG_TRIM);
 		shell.setText("Choose base branch for net-new issues scanning");
 		shell.setLayout(new GridLayout(1, false));

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/BrowserHandler.java

@@ -34,6 +34,7 @@
 
 @SuppressWarnings("restriction")
 public class BrowserHandler {
+	private static final int validNumberOfArguments = 5;
 	private Browser browser;
 	private String initScript = "";
 
@@ -45,7 +46,7 @@ public void initialize() {
 		new BrowserFunction(browser, "openInEditor") {
 			@Override
 			public Object function(Object[] arguments) {
-				if (arguments.length != 5) {
+				if (arguments.length != validNumberOfArguments) {
 					return null;
 				}
 				String filePath = (String) arguments[0];
@@ -165,7 +166,7 @@ public CompletableFuture<Void> updateBrowserContent(TreeNode node) {
 	}
 
 	private BaseHtmlProvider getHtmlProvider(TreeNode node) {
-		var product = "";
+		String product;
 		if (node instanceof IssueTreeNode) {
 			product = ((ProductTreeNode) node.getParent().getParent()).getProduct();
 		} else if (node instanceof ProductTreeNode) {

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/ProductTreeNode.java

@@ -18,7 +18,7 @@ public class ProductTreeNode extends BaseTreeNode {
 
 	public ProductTreeNode(String value) {
 		super(value);
-		this.setProduct(value);
+		initializeProduct(product);
 
 		switch (value) {
 		case ProductConstants.DISPLAYED_OSS:
@@ -37,6 +37,13 @@ public ProductTreeNode(String value) {
 			setImageDescriptor(SnykIcons.CODE);
 			prefEnablementKey = Preferences.ACTIVATE_SNYK_CODE_SECURITY;
 			break;
+	    default:
+	        // Handle unexpected values
+	        setImageDescriptor(null);
+	        prefEnablementKey = "";
+	        // Optionally, log an error or throw an exception
+	        System.err.println("Unexpected product value: " + value);
+	        break;
 		}
 
 
@@ -134,7 +141,7 @@ public String getProduct() {
 	}
 
 	public void setProduct(String product) {
-		this.product = product;
+	    initializeProduct(product);
 	}
 
 	public String getErrorMessage() {
@@ -144,4 +151,10 @@ public String getErrorMessage() {
 	public void setErrorMessage(String errorMessage) {
 		this.errorMessage = errorMessage;
 	}
+	
+	private void initializeProduct(String product) {
+		this.setProduct(product);
+	}
+
+
 }