Skip to content

Commit b2fa8bb

Browse files
committed
lint fixes in build-ci.yml
Closes #164.
1 parent f7aad13 commit b2fa8bb

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

.github/workflows/build-ci.yml

+14-14
Original file line numberDiff line numberDiff line change
@@ -537,58 +537,58 @@ jobs:
537537
echo "⚠️ Found PkgInfo in root directory - removing it"
538538
rm "${{env.APP_NAME}}.app/PkgInfo"
539539
fi
540-
540+
541541
# Ensure PkgInfo exists in the Contents directory
542542
if [[ ! -f "${{env.APP_NAME}}.app/Contents/PkgInfo" ]]; then
543543
echo "Creating PkgInfo in Contents directory"
544544
echo "APPL????" > "${{env.APP_NAME}}.app/Contents/PkgInfo"
545545
fi
546-
546+
547547
# Clear extended attributes that could interfere with signing
548548
find "${{env.APP_NAME}}.app" -type f -exec xattr -c {} \;
549-
549+
550550
# First run macdeployqt WITHOUT creating DMG yet
551551
echo "🚀 Running macdeployqt to bundle required libraries..."
552552
macdeployqt "${{env.APP_NAME}}.app" -verbose=3 || {
553553
echo "Error: macdeployqt failed."
554554
exit 1
555555
}
556-
556+
557557
# Now sign the .app bundle AFTER macdeployqt has added all dependencies
558558
echo "🔏 Sign the application bundle"
559559
codesign --deep --force --verbose \
560560
--options runtime \
561561
--entitlements ../scripts/entitlements.plist \
562562
--sign "Developer ID Application: Dimitris Kalamaras (${{ secrets.AC_TEAM_ID }})" \
563563
"${{env.APP_NAME}}.app"
564-
564+
565565
# Verify the signature
566566
echo "🔍 Verifying signature..."
567567
codesign --verify --verbose "${{env.APP_NAME}}.app"
568-
568+
569569
# Create the DMG from the signed app
570570
echo "📦 Creating DMG from signed application..."
571571
hdiutil create -volname "${{env.APP_NAME}}" -srcfolder "${{env.APP_NAME}}.app" -ov -format UDZO "${{env.APP_NAME}}.dmg"
572-
572+
573573
# Sign the DMG
574574
echo "🔏 Signing the DMG..."
575575
codesign --force --sign "Developer ID Application: Dimitris Kalamaras (${{ secrets.AC_TEAM_ID }})" "${{env.APP_NAME}}.dmg"
576-
576+
577577
# Notarize the signed DMG
578578
echo "📜 Notarize the DMG"
579579
xcrun notarytool submit "${{env.APP_NAME}}.dmg" \
580580
--keychain-profile "AC_PASSWORD" --wait
581-
581+
582582
# Check the notarization status to handle success or failure
583583
notarization_info=$(xcrun notarytool info --keychain-profile "AC_PASSWORD" "$(xcrun notarytool history --keychain-profile "AC_PASSWORD" | grep "${{env.APP_NAME}}.dmg" | head -1 | awk '{print $1}')")
584-
584+
585585
if echo "$notarization_info" | grep -q "status: Accepted"; then
586586
echo "✅ Notarization successful!"
587-
587+
588588
# Staple the notarization ticket to the DMG
589589
echo "📌 Stapling notarization ticket to DMG..."
590590
xcrun stapler staple "${{env.APP_NAME}}.dmg"
591-
591+
592592
# Rename DMG file after successful notarization and stapling
593593
DMG_NAME="${{env.APP_NAME}}-${{env.VERSION}}.dmg"
594594
mv "${{env.APP_NAME}}.dmg" "${DMG_NAME}"
@@ -598,12 +598,12 @@ jobs:
598598
else
599599
echo "❌ Notarization failed. Details:"
600600
echo "$notarization_info"
601-
601+
602602
# You might want to check for specific errors and provide guidance
603603
if echo "$notarization_info" | grep -q "issues"; then
604604
xcrun notarytool log --keychain-profile "AC_PASSWORD" "$(xcrun notarytool history --keychain-profile "AC_PASSWORD" | grep "${{env.APP_NAME}}.dmg" | head -1 | awk '{print $1}')"
605605
fi
606-
606+
607607
# Still create the artifact, but with a different name to indicate it's not notarized
608608
DMG_NAME="${{env.APP_NAME}}-${{env.VERSION}}-unsigned.dmg"
609609
mv "${{env.APP_NAME}}.dmg" "${DMG_NAME}"

0 commit comments

Comments
 (0)