Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrongly returns empty enclosure urls for http://www.tatw.co.uk/podcast.xml #7

Open
joeyh opened this issue Sep 27, 2013 · 2 comments
Open

Comments

@joeyh
Copy link

joeyh commented Sep 27, 2013

Tested with 0.3.9.1:

Prelude Text.Feed.Query Text.Feed.Import Control.Applicative> map getItemEnclosure . getFeedItems <$> parseFeedFromFile "podcast.xml"
[Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0),Just ("",Nothing,0)]

The enclosures in the have non-null urls when you look at it. The W3C feed validator says it fails to validate due to a number of silly issues, but does not come up with any problems with its enclosures.

@sof
Copy link
Owner

sof commented Sep 28, 2013

The feed validator does try to tell you that the feed is invalid -- RSS2 s must have a description,

http://cyber.law.harvard.edu/rss/rss.html#requiredChannelElements

but this feed doesn't have any. Hence it fails to parse by the RSS2 parser/importer.

This library tries to make a best effort in case of feed parse errors, but the code paths that work with this untyped representation is less exercised. And it is preferable if we can avoid an untyped/unparseable representation to start with.

Push a pair of fixes; allowing such description-less RSS2 feeds to parse + fixed a bug in the untyped case for getItemEnclosure.

@joeyh
Copy link
Author

joeyh commented Feb 10, 2015

Does "push a pair of fixes" mean this got fixed? Bug is still listed as open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants