Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traceId 支持自定义 #235

Open
taotao365s opened this issue Jul 16, 2019 · 8 comments
Open

traceId 支持自定义 #235

taotao365s opened this issue Jul 16, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request waiting for feedback waiting for feedback
Milestone

Comments

@taotao365s
Copy link

taotao365s commented Jul 16, 2019

Your question

目前tracerId很不直观,尤其是把进程PID放在末尾,误认为tracerId没有变化

建议:

  • 将自增序列放在最后
  • 开放tracerId生成接口

describe your question clearly

Your scenes

describe your use scenes (why need this feature)

Your advice

describe the advice or solution you'd like

Environment

  • SOFATracer version:
  • JVM version (e.g. java -version):
  • OS version (e.g. uname -a):
  • Maven version:
  • IDE version:
@glmapper
Copy link
Contributor

Are there any specific suggestions? Of course, if the rules for generating tracerId can be customized, it is best. You can provide a PR to support custom generation rules.

@glmapper glmapper added the enhancement New feature or request label Jul 16, 2019
@glmapper glmapper added the waiting for feedback waiting for feedback label Jul 26, 2019
@rayzeng
Copy link

rayzeng commented Sep 7, 2019

要做全流程traceid,会有从客户端生产的场景,希望有支持自定义设置的能力

@yinay
Copy link

yinay commented Sep 29, 2020

Another scenario, how to support upstream Application TraceId, which is generated by SkyWalking.

@glmapper glmapper self-assigned this Dec 7, 2020
@glmapper glmapper added this to the 3.1.0 milestone Dec 7, 2020
@glmapper
Copy link
Contributor

glmapper commented Dec 7, 2020

要做全流程traceid,会有从客户端生产的场景,希望有支持自定义设置的能力

如果你的应用和你的下游应用使用的产生 tracerId 的生成策略是不一致的,那么就可能会导致我们整个链路错乱。提供扩展生成 tracerId 是个非常简单的事情,但是由此带来的一些链路正确性和安全性问题就没有办法得以保障。

@glmapper glmapper modified the milestones: 3.1.0, 3.1.1 Feb 20, 2021
@chenmudu
Copy link
Contributor

chenmudu commented Mar 9, 2021

所以这个issue讨论的结果,是否需要做 traceId 默认生成规则的修改(traceId变化更加明显)以及是否去支持用户自定义traceId? @glmapper

@khotyn
Copy link
Member

khotyn commented Mar 10, 2021

如果提供自定义的 traceId,关键还是要看自定义的 traceId 能否保证全局的唯一性。

@chenmudu
Copy link
Contributor

如果提供自定义的 traceId,关键还是要看自定义的 traceId 能否保证全局的唯一性。

😀 个人认为, 也许可以开放给用户,由用户自行去保证唯一性。

@taotao365s
Copy link
Author

如果提供自定义的 traceId,关键还是要看自定义的 traceId 能否保证全局的唯一性。

😀 个人认为, 也许可以开放给用户,由用户自行去保证唯一性。

  • 保持现有默认规则
  • 增加扩展,至于使用由用户来保证即可

@glmapper glmapper modified the milestones: 3.1.1, 3.1.2 Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting for feedback waiting for feedback
Projects
None yet
Development

No branches or pull requests

6 participants