Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staple Architecture with basic testing #32

Open
wants to merge 20 commits into
base: predeploy
Choose a base branch
from
Open

Staple Architecture with basic testing #32

wants to merge 20 commits into from

Conversation

shanilpanara
Copy link
Member

@shanilpanara shanilpanara commented Feb 17, 2021 •
edited
Loading

Summary

First 5 weeks of Masters Project - Coding Progress:

  • StapleAlgorithm1 - an algorithm which generates some staples on a scaffold which we wouldn't really use in real life however it was made more complicated than necessary to develop the StapleBaseClass.
  • StapleBaseClass - will add more to Staple architecture #27 for more indepth description of the architecture. But:
    • this is able to both extract relevant properties from any scaffold generated through the programme (given it is a LatticeRoute)
    • it sets up a multidimensional array (lattice) which stores information about each nucleotide
    • this lattice can be read to generate staples (using a StaplingAlgorithm) and written to (by `write_staples_to_array)
    • finally, we can read the lattice and convert every staple to an oxDNA strand, outputting this collection in a StapleContainer in which we can write methods to edit the collection of staples to generate multiple possible configurations

Further updates

  • 17/02/21: Added a "check this even runs" test with more advanced pytest features

@shanilpanara shanilpanara linked an issue Feb 17, 2021 that may be closed by this pull request
Trouble importing staple classes from sandbox for testing #33
Closed
@shanilpanara shanilpanara removed a link to an issue Feb 17, 2021
Trouble importing staple classes from sandbox for testing #33
Closed
@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #32 (78da6ab) into predeploy (fb61f1f) will increase coverage by 4.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           predeploy      #32      +/-   ##
=============================================
+ Coverage      75.39%   79.62%   +4.23%     
=============================================
  Files             14       14              
  Lines           1345     1345              
=============================================
+ Hits            1014     1071      +57     
+ Misses           331      274      -57
Impacted Files Coverage Δ
drawNA/lattice/route.py 74.19% <100.00%> (+13.97%) ⬆️
drawNA/lattice/utils.py 71.87% <0.00%> (+3.12%) ⬆️
drawNA/lattice/_lattice.py 68.45% <0.00%> (+12.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb61f1f...78da6ab. Read the comment docs.

@shanilpanara shanilpanara linked an issue Feb 17, 2021 that may be closed by this pull request
Staple architecture #27
Open
@debeshmandal debeshmandal changed the base branch from master to predeploy February 18, 2021 15:25
@shanilpanara
Copy link
Member Author

@debeshmandal from looking at the build errors, it seems they are due to a softnanotools import error, how do I go about solving this?

@debeshmandal
Copy link
Member

@debeshmandal from looking at the build errors, it seems they are due to a softnanotools import error, how do I go about solving this?

Just add softnanotools to the imports in the file .github/workflows/*.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debeshmandal debeshmandal Awaiting requested review from debeshmandal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Staple architecture
2 participants
@shanilpanara @debeshmandal