Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count of repo watchers is not provided #239

Open
awaitlink opened this issue Jan 1, 2020 · 1 comment
Open

Count of repo watchers is not provided #239

awaitlink opened this issue Jan 1, 2020 · 1 comment

Comments

@awaitlink
Copy link

Presently hubcaps offers these fields regarding watchers, stars, and forks count in hubcaps::repositories::Repo:

hubcaps/src/repositories.rs

Lines 515 to 517 in d2d61ac

pub forks_count: u64,
pub stargazers_count: u64,
pub watchers_count: u64,

However, note that for legacy support reasons, watchers_count is the count of stars as well:

https://api.github.com/repos/softprops/hubcaps
{
  "forks_count": 41,
  "stargazers_count": 166,
  "watchers_count": 166,

  "subscribers_count": 4
}

Instead, subscribers_count should be offered, since that is the actual repo watcher count.

The same might need to be done in hubcaps::search::ReposItem as well.

@JosephLing
Copy link

Can I take this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants