-
Notifications
You must be signed in to change notification settings - Fork 437
[WIP] http4s - migrate from Blaze to Ember #4185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[WIP] http4s - migrate from Blaze to Ember #4185
Conversation
16a531e
to
cd1ce53
Compare
088bbfa
to
6aa2b66
Compare
f0b3c83
to
57c2fa6
Compare
Oh nice, I was worried you abandoned the PR ;) |
Will wait for #4267 first |
@ivan-klass sure thing, done :) |
3fe8b8e
to
8b5ea8a
Compare
To whom it may concern: ember builder doesn't have an option for a specific execution context, so test request handling is not in the global one as it was before. It seems like race conditions are observed when dealing with some web-socket tests. |
@ivan-klass sorry for the delay - the global EC was used before only because it was the easiest one to obtain ;). I don't think there's anything in the tests that would rely on the global one being used: each server should be independent anyway, regardless on the thread pool on which tasks/futures are scheduled. So I would look for causes of the exceptions elsewhere, unfortunately. |
Then there might be a bug in http4-ember then... I'll try to dig in and reproduce when I have time |
Ember seems to be more modern and especially better supported in terms of cross-platform builds