Skip to content

[WIP] http4s - migrate from Blaze to Ember #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

ivan-klass
Copy link
Contributor

Ember seems to be more modern and especially better supported in terms of cross-platform builds

@ivan-klass ivan-klass force-pushed the http4s-migrate-to-ember branch from 16a531e to cd1ce53 Compare November 25, 2024 18:53
@ivan-klass ivan-klass marked this pull request as ready for review November 25, 2024 18:54
@ivan-klass ivan-klass force-pushed the http4s-migrate-to-ember branch 2 times, most recently from 088bbfa to 6aa2b66 Compare November 30, 2024 11:37
@ivan-klass ivan-klass force-pushed the http4s-migrate-to-ember branch 2 times, most recently from f0b3c83 to 57c2fa6 Compare December 19, 2024 16:50
@adamw
Copy link
Member

adamw commented Dec 19, 2024

Oh nice, I was worried you abandoned the PR ;)

@ivan-klass
Copy link
Contributor Author

Will wait for #4267 first

@ivan-klass ivan-klass changed the title http4s - migrate from Blaze to Ember [WIP, depends on #4267] http4s - migrate from Blaze to Ember Jan 23, 2025
@ivan-klass
Copy link
Contributor Author

@adamw when you have a chance, could you please take a look on #4267 so I can rebase this PR on top of that?

@adamw
Copy link
Member

adamw commented Jan 31, 2025

@ivan-klass sure thing, done :)

@ivan-klass ivan-klass force-pushed the http4s-migrate-to-ember branch from 3fe8b8e to 8b5ea8a Compare February 1, 2025 13:25
@ivan-klass ivan-klass changed the title [WIP, depends on #4267] http4s - migrate from Blaze to Ember [WIP] http4s - migrate from Blaze to Ember Feb 1, 2025
@ivan-klass
Copy link
Contributor Author

To whom it may concern: ember builder doesn't have an option for a specific execution context, so test request handling is not in the global one as it was before. It seems like race conditions are observed when dealing with some web-socket tests.

@adamw
Copy link
Member

adamw commented Mar 21, 2025

@ivan-klass sorry for the delay - the global EC was used before only because it was the easiest one to obtain ;). I don't think there's anything in the tests that would rely on the global one being used: each server should be independent anyway, regardless on the thread pool on which tasks/futures are scheduled. So I would look for causes of the exceptions elsewhere, unfortunately.

@ivan-klass
Copy link
Contributor Author

Then there might be a bug in http4-ember then... I'll try to dig in and reproduce when I have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants