From 9ff7bbecb00890d1bd9b30134c01f1b403531e47 Mon Sep 17 00:00:00 2001
From: Beth Skurrie <beth@bethesque.com>
Date: Tue, 10 Mar 2020 07:46:28 +1100
Subject: [PATCH] feat(clean): all the latest version for all tags to be kept

---
 lib/pact_broker/domain/version.rb           | 26 ++++++----
 spec/lib/pact_broker/domain/version_spec.rb | 55 ++++++++++++++++++++-
 2 files changed, 70 insertions(+), 11 deletions(-)

diff --git a/lib/pact_broker/domain/version.rb b/lib/pact_broker/domain/version.rb
index 6a5c3fd72..5162a4315 100644
--- a/lib/pact_broker/domain/version.rb
+++ b/lib/pact_broker/domain/version.rb
@@ -27,11 +27,15 @@ def where_pacticipant_name(pacticipant_name)
         end
 
         def where_tag(tag)
-          join(:tags) do | tags |
-            Sequel.&(
-              { Sequel[first_source_alias][:id] => Sequel[tags][:version_id] },
-              name_like(Sequel[tags][:name], tag)
-            )
+          if tag == true
+            join(:tags, Sequel[:tags][:version_id] => Sequel[first_source_alias][:id])
+          else
+            join(:tags) do | tags |
+              Sequel.&(
+                { Sequel[first_source_alias][:id] => Sequel[tags][:version_id] },
+                name_like(Sequel[tags][:name], tag)
+              )
+            end
           end
         end
 
@@ -57,7 +61,7 @@ def for_selector(selector)
           query = query.where_age_less_than(selector.max_age) if selector.max_age
 
           if selector.latest
-            select_max_order_for_each_pacticipant_and_join_back_to_versions(query)
+            calculate_max_version_order_and_join_back_to_versions(query, selector)
           else
             query
           end
@@ -65,17 +69,19 @@ def for_selector(selector)
 
         # private
 
-        def select_max_order_for_each_pacticipant_and_join_back_to_versions(query)
-          join = {
+        def calculate_max_version_order_and_join_back_to_versions(query, selector)
+          versions_join = {
             Sequel[:versions][:pacticipant_id] => Sequel[:latest][:pacticipant_id],
             Sequel[:versions][:order]          => Sequel[:latest][:latest_version_order]
           }
 
+          group_by_cols = selector.tag == true ? [:pacticipant_id, Sequel[:tags][:name]] : [:pacticipant_id]
+
           max_order_for_each_pacticipant = query
-              .select_group(:pacticipant_id)
+              .select_group(*group_by_cols)
               .select_append{ max(order).as(latest_version_order) }
 
-          join(max_order_for_each_pacticipant, join, table_alias: :latest)
+          join(max_order_for_each_pacticipant, versions_join, table_alias: :latest)
         end
       end
 
diff --git a/spec/lib/pact_broker/domain/version_spec.rb b/spec/lib/pact_broker/domain/version_spec.rb
index 60b61a7ba..297bc63d6 100644
--- a/spec/lib/pact_broker/domain/version_spec.rb
+++ b/spec/lib/pact_broker/domain/version_spec.rb
@@ -3,7 +3,6 @@
 module PactBroker
   module Domain
     describe Version do
-
       describe "for_selector" do
         subject { Version.for_selector(selector).all }
 
@@ -68,6 +67,60 @@ def version_numbers
           end
         end
 
+        context "when selecting the latest version for each tag (head versions)" do
+          before do
+            td.create_consumer("Foo")
+              .create_consumer_version("1", tag_names: %w{prod})
+              .create_consumer_version("2", tag_names: %w{prod}).comment("yes")
+              .create_consumer_version("3", tag_names: %w{master})
+              .create_consumer_version("4", tag_names: %w{master}).comment("yes")
+              .create_consumer("Bar")
+              .create_consumer_version("10", tag_names: %w{prod})
+              .create_consumer_version("11", tag_names: %w{prod}).comment("yes")
+          end
+
+          let(:selector) { PactBroker::Matrix::UnresolvedSelector.new(tag: true, latest: true) }
+
+          it "selects the head versions for each tag" do
+            expect(version_numbers.sort).to eq %w{11 2 4}
+          end
+
+          context "when also specifying pacticipant name" do
+            let(:selector) { PactBroker::Matrix::UnresolvedSelector.new(tag: true, latest: true, pacticipant_name: "Foo") }
+
+            it "selects the head versions for each tag for the given pacticipant" do
+              expect(version_numbers.sort).to eq %w{2 4}
+            end
+          end
+        end
+
+        context "when selecting all tagged versions" do
+          before do
+            td.create_consumer("Foo")
+              .create_consumer_version("1", tag_names: %w{prod})
+              .create_consumer_version("2", tag_names: %w{prod})
+              .create_consumer_version("4", tag_names: %w{master})
+              .create_consumer_version("5")
+              .create_consumer("Bar")
+              .create_consumer_version("10", tag_names: %w{prod})
+              .create_consumer_version("11")
+          end
+
+          let(:selector) { PactBroker::Matrix::UnresolvedSelector.new(tag: true) }
+
+          it "selects every version with a tag" do
+            expect(version_numbers.sort).to eq %w{1 10 2 4}
+          end
+
+          context "when also specifying pacticipant name" do
+            let(:selector) { PactBroker::Matrix::UnresolvedSelector.new(tag: true, pacticipant_name: "Foo") }
+
+            it "selects every version with a tag for the given pacticipant" do
+              expect(version_numbers.sort).to eq %w{1 2 4}
+            end
+          end
+        end
+
         context "when selecting all versions for a tag with max age" do
           before do
             td.set_now(four_days_ago)