chore: pin pnpm for corepack (#1831)

Author: atilafassina

.github/workflows/cr.yml

@@ -20,14 +20,12 @@ jobs:
       - uses: actions/checkout@v4
 
       - uses: pnpm/action-setup@v3
-        with:
-          # https://github.com/pnpm/pnpm/issues/8953
-          version: 9.15.3
 
-      - name: Use Node.js 20
+      - name: Use Node.js from .nvmrc
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version-file: ".nvmrc"
+          registry-url: "https://registry.npmjs.org"
           cache: "pnpm"
 
       - name: Install dependencies

.github/workflows/release.yml

@@ -16,15 +16,13 @@ jobs:
         uses: actions/checkout@v3
 
       - uses: pnpm/action-setup@v3
-        with:
-          # https://github.com/pnpm/pnpm/issues/8953
-          version: 9.15.3
 
       - name: Use Node.js from nvmrc
         uses: actions/setup-node@v4
         with:
           node-version-file: ".nvmrc"
           registry-url: "https://registry.npmjs.org"
+          cache: "pnpm"
 
       - name: Install Dependencies
         run: pnpm i --frozen-lockfile

.github/workflows/tests.yml

@@ -10,13 +10,17 @@ on:
 jobs:
   tests:
     name: "🧪 Tests"
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v3
       - uses: pnpm/action-setup@v4
+
+      - name: Use Node.js from nvmrc
+        uses: actions/setup-node@v4
         with:
-          # https://github.com/pnpm/pnpm/issues/8953
-          version: 9.15.3
+          node-version-file: ".nvmrc"
+          registry-url: "https://registry.npmjs.org"
+          cache: "pnpm"
 
       - name: Install project dependencies
         run: pnpm i
@@ -36,18 +40,22 @@ jobs:
           working-directory: .
           runTests: false
 
-      - name: E2E Firefox
+      - name: E2E Chromium
         uses: cypress-io/github-action@v6
         with:
           install: false
           working-directory: packages/tests
-          start: pnpm start
-          browser: firefox
+          start: pnpm start --host 127.0.0.1 --port 3000
+          wait-on: 'http://127.0.0.1:3000'
+          browser: chromium
 
-      - name: E2E Chromium
+      - name: E2E Firefox
         uses: cypress-io/github-action@v6
         with:
           install: false
           working-directory: packages/tests
-          start: pnpm start
-          browser: chromium
+          start: pnpm start --host 127.0.0.1 --port 3000
+          wait-on: 'http://127.0.0.1:3000'
+          browser: firefox
+
+

.github/workflows/typecheck.yml

@@ -46,14 +46,12 @@ jobs:
       - uses: actions/checkout@v4
 
       - uses: pnpm/action-setup@v3
-        with:
-          # https://github.com/pnpm/pnpm/issues/8953
-          version: 9.15.3
 
-      - name: Use Node.js ${{ matrix.node-version }}
+      - name: Use Node.js from .nvmrc
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version-file: ".nvmrc"
+          registry-url: "https://registry.npmjs.org"
           cache: "pnpm"
 
       - name: Install dependencies

package.json

@@ -40,6 +40,8 @@
   },
   "dependencies": {},
   "engines": {
-    "pnpm": "^9.0.0"
-  }
+    "pnpm": "^9.15.0",
+    "node": ">=22"
+  },
+  "packageManager": "pnpm@9.15.0"
 }

packages/tests/app.config.ts

@@ -1,5 +1,3 @@
 import { defineConfig } from "@solidjs/start/config";
 
-export default defineConfig({
-  ssr: false
-});
+export default defineConfig();

packages/tests/cypress/e2e/hydration.cy.ts

@@ -0,0 +1,12 @@
+describe("hydration", () => {
+    it("should have interactivity", () => {
+        cy.visit("/");
+        cy.get("#counter-button").trigger("click")
+        cy.get("#counter-output").contains("1");
+    });
+
+    it("should have isServer false in the client", () => {
+        cy.visit("/client-only");
+        cy.get("#server-fn-test").contains('{"clientWithIsServer":false}');
+    });
+});

packages/tests/cypress/e2e/server-function.cy.ts

@@ -1,8 +1,4 @@
 describe("server-function", () => {
-  it("should have isServer false in the client", () => {
-    cy.visit("/");
-    cy.get("#server-fn-test").contains('{"clientWithIsServer":false}');
-  });
   it("should have isServer true in the server function - nested", () => {
     cy.visit("/is-server-nested");
     cy.get("#server-fn-test").contains('{"serverFnWithIsServer":true}');

packages/tests/package.json

@@ -23,9 +23,9 @@
     "@vitest/ui": "3.0.5",
     "jsdom": "^25.0.1",
     "lodash": "^4.17.21",
-    "solid-js": "^1.9.4",
+    "solid-js": "^1.9.5",
     "vinxi": "^0.5.3",
-    "vite-plugin-solid": "^2.11.1",
+    "vite-plugin-solid": "^2.11.6",
     "vitest": "3.0.5"
   },
   "engines": {

packages/tests/src/app.tsx

@@ -12,7 +12,10 @@ export default function App() {
           <Title>SolidStart - Basic</Title>
           <ul>
             <li>
-              <a href="/">Client</a>
+              <a href="/">Basic</a>
+            </li>
+            <li>
+              <a href="/client-only">Client-Only</a>
             </li>
             <li>
               <a href="/is-server-nested">isserver (nested)</a>

packages/tests/src/routes/(basic).tsx

@@ -0,0 +1,12 @@
+import { createSignal } from "solid-js";
+
+export default function App() {
+  const [counter, setCounter] = createSignal<number>(0);
+  
+  return (
+    <main>
+      <span id="counter-output">{counter()}</span>
+      <button id="counter-button" onClick={() => setCounter(n => n + 1)}>one more</button>
+    </main>
+  );
+}

packages/tests/src/routes/client-only/_component.tsx

@@ -0,0 +1,14 @@
+import { createSignal } from "solid-js";
+import { isServer } from "solid-js/web";
+
+
+export default function ClientOnlyComponent() {
+    const [output, setOutput] = createSignal<{ clientWithIsServer?: boolean; }>({});
+
+    setOutput(prev => ({ ...prev, clientWithIsServer: isServer }));
+  
+    return (
+        <main>
+        <span id="server-fn-test">{JSON.stringify(output())}</span>
+      </main>)
+}

packages/tests/src/routes/client-only/index.tsx

@@ -0,0 +1,12 @@
+import { clientOnly } from "@solidjs/start";
+
+const Component = clientOnly(() => import('./_component'))
+
+export default function App() {
+
+  return (
+    <>
+        <Component />
+    </>
+  );
+}