Ignore requests in tests

[cloudlena]

As described in the docs, http.NewRequest uses the context.Background context which is supposed to be used in tests according to the docs. Therefore, it is cleaner to use http.NewContext in tests where we make HTTP requests against test servers.

Therefore, I think the linter should allow the usage of http.NewRequest, http.Get, http.Header and all similar functions in tests because it's the recommended way and provides much simpler code than having to explicitly use http.NewRequestWithContext with context.Background each time.

[sonatard]

Thank you for opening your issue! I'll fix it.

[sonatard]

If you need a quick fix, please use golangci-lint.

Usage
https://github.com/sonatard/noctx#noctx-with-golangci-lint

Exec golangci-lint without test files.
https://github.com/golangci/golangci-lint/blob/d287af010a7199b552ace8c6ab6ebcacf23b8cf4/.golangci.example.yml#L16

[cloudlena]

Thanks for the hint. I actually do want to lint my test files. Just not for the usage of the context :) For now, I just excluded noctx in .golangci.yml and will activate it again as soon as this issue is fixed.

[sonatard]

I understand your situation.

Can you try again golangci-lint with following .golangci.yml ?

issues:
  exclude-rules:
    - path: _test\.go
      linters:
        - noctx

[cloudlena]

Thanks, @sonatard. That's a good temporary workaround!