Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension not loading in VS2019 16.1 and above due to use of deprecated APIs #30

Open
allisterb opened this issue Aug 1, 2019 · 14 comments

Comments

@allisterb
Copy link
Contributor

This change to how Visual Studio loads extensions affects audit.net:
https://devblogs.microsoft.com/visualstudio/updates-to-synchronous-autoload-of-extensions-in-visual-studio-2019/

The extension needs to be updated to use the new background load method:
https://github.com/microsoft/VSSDK-Extensibility-Samples/tree/master/AsyncPackageMigration

@markusschaber
Copy link

I just want to ask whether there's any progress here, or whether we can help / contribute to get this issue fixed?

@OSSIndex-Admin
Copy link
Contributor

OSSIndex-Admin commented Nov 6, 2019 via email

@allisterb
Copy link
Contributor Author

@markusschaber Could you try the build for VS 2019? Just unzip and double-click.
NugetAuditor.VSIX.zip

@markusschaber
Copy link

markusschaber commented Nov 7, 2019

It won't install in VS 2019, it seems. Are there any prerequisite packages required?
grafik

@OSSIndex-Admin
Copy link
Contributor

So to be clear, @markusschaber , I have reproduced your problem. I can install the older version using the above workaround, and am trying to resolve the above problem (though my C#/VS skills are minimal). We will be expanding the team very soon, so if we cannot get a better solution soon we will have a team in place that should be able to handle it soon.

Sorry it is taking so long. Assembling the team is proving to be somewhat more time consuming than I originally anticipated.

@OSSIndex-Admin
Copy link
Contributor

I have deleted a lot of the previous blather. I should really not respond till I collect more information...

Here is a version of the package which should work. I was able to reproduce the problem, and managed to figure out the solution. Sorry again for the delay. We are working on that.

NugetAuditor.VSIX.vsix.zip

I am leaving this open until it has been successfully uploaded to the marketplace.

@markusschaber
Copy link

markusschaber commented Nov 29, 2019

Thanks a lot for your efforts.
This one installed successfully in VS 2019, but failed to install in 2017.
As I'm mostly using VS 2019 now, I can live with that. :-)

grafik

Translation: Installation failed as it's missing a reference to "Visual Studio MPF 16.0"

@OSSIndex-Admin
Copy link
Contributor

Ha. Figures. I can build for one or the other currently. I will look into making it do both, but due to some changes that we had to make recently it might be easier just having two separate installs.

I'll work at it a bit over the next few days, but will have a new release built either that does both, or two separate versions that are both up to date soon. Thanks for the help!

@markusschaber
Copy link

Thanks for your great work!

@allisterb
Copy link
Contributor Author

@markusschaber I'm really sorry it took me so long to get back to you. Could you try this version on your VS 2017 instance:
NugetAuditor.VSIX.zip

@markusschaber
Copy link

It installed without errors in VS 2017 (and did not offer to install in VS 2019).

A small smoke test (Auditing 87 packages in solution) also seemingly worked fine.

@MrChrisWeinert
Copy link

Version 3.4.0 (that you linked in this discussion) is working great in VS 2019. Thanks for building this great extension.

@felickz
Copy link

felickz commented Apr 22, 2021

Still getting this with VS2019 using latest deployed extension 3.0.5 ... any plans to publish new?

image

https://devblogs.microsoft.com/visualstudio/updates-to-synchronous-autoload-of-extensions-in-visual-studio-2019/

@mushu999
Copy link

Since this has STILL not been updated to install properly from within the VS extensions window, and the zip in the post above does not contain an installer like the VS2019 version does (in a higher post above), can someone please explain how to manually install the VS2017 zipped version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants