Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gNOI System Reboot RPC calling Config Reload instead of Reboot #204

Open
ndas7 opened this issue Mar 22, 2024 · 0 comments
Open

gNOI System Reboot RPC calling Config Reload instead of Reboot #204

ndas7 opened this issue Mar 22, 2024 · 0 comments
Assignees

Comments

@ndas7
Copy link

ndas7 commented Mar 22, 2024

The gNOI System Reboot RPC is defined as causes the target to reboot, possibly at some point in the future...the command will block until the subcomponents have restarted. Reference: https://github.com/openconfig/gnoi/blob/main/system/system.proto#L70

However, the sonic-gnmi implementation of the gNOI Reboot service does a Config reload and not a System Reboot. Reference: https://github.com/sonic-net/sonic-gnmi/blob/master/gnmi_server/gnoi.go#L29 This does not align with the intended System Reboot command and needs to be updated to trigger a system reboot instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants