Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the wrong key in DPU address get from DHCP_SERVER_IPV4_PORT table Issue #288 #289

Closed
wants to merge 3 commits into from
Closed

fix the wrong key in DPU address get from DHCP_SERVER_IPV4_PORT table Issue #288 #289

wants to merge 3 commits into from

Conversation

aronovic
Copy link

Fixes #288

Why I did it

gnmi_set.go:203] Set failed: rpc error: code = NotFound desc = Get ZMQ client failed: Get ZMQ address failed: Get DPU address failed: Can't read bridge-midplane|dpu1:ips from DHCP_SERVER_IPV4_PORT table

How I did it

Modified the key from ips to ips@ as expected in the table

How to verify it

Executed my gnmi client and was able to retrieve the entry successfully

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Modified the key used for DPU address retrieval by gnmi_set from DHCP_SERVER_IPV4_PORT table

Link to config_db schema for YANG module changes

N/A

A picture of a cute animal (not mandatory but encouraged)

@aronovic
fix the wrong key in DPU address get from DHCP_SERVER_IPV4_PORT table
1427d39 
Signed-off-by: Mihut Aronovici <aronovic@cisco.com>
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 19, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@ganglyu
Copy link
Contributor

ganglyu commented Sep 23, 2024

Please fix EasyCLA

@sallylsy
Copy link
Contributor

sallylsy commented Oct 7, 2024

Component test failed

=== RUN   TestGetDpuAddress
    client_test.go:741: get DPU address failed: Can't read bridge-midplane|dpu0:ips@ from DHCP_SERVER_IPV4_PORT table
    client_test.go:745: get DPU address failed: 
    client_test.go:761: get invalid DPU address failed
--- FAIL: TestGetDpuAddress (0.01s)

Please fix

@aronovic aronovic closed this Oct 28, 2024
@aronovic
Copy link
Author

This issue has been fixed in another PR so this one is not needed anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gnmi_set fails to get DPU address
3 participants
@aronovic @ganglyu @sallylsy