Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Member page metadata retrieval errors #138

Closed
amenconi opened this issue Mar 13, 2024 · 3 comments · Fixed by #139
Closed

Member page metadata retrieval errors #138

amenconi opened this issue Mar 13, 2024 · 3 comments · Fixed by #139
Assignees
Labels
bug Something isn't working

Comments

@amenconi
Copy link
Contributor

Bug Description:
When the member page loads (any page with the member profile drawer open such as member activity, awards, spaces etc.) in some cases the member or spaces array returns malformed data (i.e. in the array of spaces you might find [object object] string instead of space meta data such as the UID and other properties). This will cause the Data Service to make invalid calls to the API and the HTML template will attempt to access UID property on objects where they don't exist.

Reproduce:
Navigate to "https://soonaverse.com/member/0x3ffbc221b2215d6e7d9c863fb44616a1ae042017/badges" (one of my Soonaverse accounts) with dev tools console open and you will see some failed calls to API as well as number errors such as:

ERROR TypeError: Cannot read properties of undefined (reading 'uid')
    at DefaultIterableDiffer.trackByUid [as _trackByFn] (member-about.component.ts:67:17)
    at DefaultIterableDiffer.check (core.mjs:26476:36)
    at DefaultIterableDiffer.diff (core.mjs:26457:18)
    at NgForOf.ngDoCheck (common.mjs:3092:42)
    at callHook (core.mjs:2498:18)
    at callHooks (core.mjs:2457:17)
    at executeCheckHooks (core.mjs:2389:5)
    at selectIndexInternal (core.mjs:9147:17)
    at Module.ɵɵadvance (core.mjs:9136:5)
    at MemberAboutComponent_Template (member-about.component.html:152:10)

Expected behavior:
Loading the page shouldn't produce any of these errors regardless of account loaded.

Screenshots
Image:
image
Video: https://github.com/soonaverse/app/assets/7841580/54145a1c-2be2-4420-9446-3139c8633d57

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 122.0.6261.112
@amenconi amenconi self-assigned this Mar 13, 2024
@amenconi amenconi added the bug Something isn't working label Mar 13, 2024
@emmap3-do
Copy link
Contributor

@amenconi there is an old issue I found in production last year, related to the uid, that might be fixed with these changes.
I'm adding it here for reference: #53

@amenconi
Copy link
Contributor Author

@emmap3-do ah yes, familiar with this function. The checkout button pops up from the header component. Had to refactor much of that code to make this feature work with the cart and bulk buy purchase processes as well.

Hopefully this PR or the shopping cart fixes issue #53, if that bug remains after merging both I can revisit and review specifically to fix but I'm hopeful it'll be resolved with one of these.

Thanks.

@amenconi amenconi linked a pull request Mar 14, 2024 that will close this issue
@amenconi amenconi reopened this Mar 14, 2024
@emmap3-do
Copy link
Contributor

I just tested and, unfortunately, bug is still there for issue #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
2 participants