Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline issue references generate error spam #127

Open
dgw opened this issue Jun 13, 2023 · 2 comments
Open

Inline issue references generate error spam #127

dgw opened this issue Jun 13, 2023 · 2 comments

Comments

@dgw
Copy link
Member

dgw commented Jun 13, 2023

In a channel where people like to talk about numbered stuff in contexts other than issues, it's pretty easy to trigger errors from sopel-github when a number higher than the maximum issue/PR number in the linked repo is mentioned.

We should suppress "[GitHub] API says this is an invalid issue" errors for inline refs without a (user/)repo attached.

@dgw dgw added this to the 0.5.0 milestone Jun 13, 2023
@dgw
Copy link
Member Author

dgw commented Dec 19, 2023

Another edge case: A link such as https://docs.github.com/en/site-policy/acceptable-use-policies/github-acceptable-use-policies#4-spam-and-inauthentic-activity-on-github generates an error because the plugin looks for an issue at acceptable-use-policies/github-acceptable-use-policies#4 (which doesn't exist, at time of writing).

In summary:

  • Suppress errors for bare #123 inline refs with no (user/)repo component
  • Don't look for inline refs inside links, and probably just require a word boundary before and after the whole ref

@dgw
Copy link
Member Author

dgw commented May 4, 2024

Errors are blanket-suppressed with #136. For a more nuanced approach, as noted in that PR, it would be better to wait until after some long-overdue code cleanup/refactoring can happen.

@dgw dgw removed this from the 0.5.0 milestone May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant