Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex Failure #132

Open
ghost opened this issue Jan 23, 2024 · 1 comment
Open

Regex Failure #132

ghost opened this issue Jan 23, 2024 · 1 comment

Comments

@ghost
Copy link

ghost commented Jan 23, 2024

Current regex doesn't match https://github.com/gnomon-/furby-source

@dgw
Copy link
Member

dgw commented Jan 23, 2024

Blame the source of the username regex, which has an issue about this problem: shinnn/github-username-regex#4

It seems the username rules about trailing hyphens changed at some point, but GH allowed existing accounts to keep them.

(If you want to throw more fun into the FOSS world, one of the test cases in GrantBirki/github-username-regex-js's readme is a trailing hyphen that's expected not to be valid 🙃)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant