Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a better job of accounting for secondary errors #17

Open
sorear opened this issue Jun 27, 2016 · 0 comments
Open

Do a better job of accounting for secondary errors #17

sorear opened this issue Jun 27, 2016 · 0 comments

Comments

@sorear
Copy link
Owner

sorear commented Jun 27, 2016

smetamath3 always continues after errors, and generate cache data including those errors. This is important for the language server use case, because we want to be able to start with an initially invalid file and enjoy the fruits of caching while evolving it into a valid file, but it does mean that errors, especially syntax errors, can produce a large number of secondary errors.

Probably the best fix here is to tag each diagnostic with the phase in which it is discovered, and then suppress any diagnostic and its associated notes if there is a textually earlier diagnostic from a strictly preceding phase with severity Error.

We could try to get fancier with identifying the relationship between primary and secondary errors, but that skirts uncomfortably close to "Read Your Mind" functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant