Omero web 5.6 compatability (#8)

* Added Python3 Support
* Made templates compatible with django 1.11
* Fixed ice objects and used JsonResponse
* Update sdist build and bump to version 1.1.0
* Remove non-pip install instructions
* Fixed typo in README
* Updated release script for pypi changes

Author: dpwrussell

README.rst

@@ -70,15 +70,13 @@ Once the user has populated the form to their satisfaction and it is valid, the
 Centre Panel Plugin - History
 =============================
 
-The centre penal plugin History is where users can view the history of metadata for the current OMERO object.
+The centre panel plugin History is where users can view the history of metadata for the current OMERO object.
 
 The list of changes in reverse chronological order are presented on the left along with the timestamp at which they were entered, the user name of the editor and the change message (if present). Selecting any of these changes will render the form that was used to enter those changes on the right, populated with the metadata that was submitted in that change.
 
 Installation
 ============
 
-The recommended installation makes use of `pip`, but other options are possible as documentated `in the offical OME docs <https://www.openmicroscopy.org/site/support/omero5/developers/Web/CreateApp.html#add-your-app-location-to-your-pythonpath>`_.
-
 Before configuring the plugin, create an administrative user in OMERO. In this example that user is called 'formmaster'. This user should not be a member of any groups other than the 'system' group that all administrators are a part of. Give this user a secure password. This can be done with the CLI.
 
 ::

omero_forms/settings.py

@@ -7,12 +7,12 @@
         "OMERO_FORMS_PRIV_USER",
         None,
         str,
-        "The priviledged username to be used for storing key-values"
+        "The priviledged username to be used for storing key-values",
     ],
     "omero.web.forms.priv.password": [
         "OMERO_FORMS_PRIV_PASSWORD",
         None,
         str,
-        "The priviledged user's password to be used for storing key-values"
+        "The priviledged user's password to be used for storing key-values",
     ],
 }

omero_forms/templates/forms/forms_init.js.html

@@ -1,5 +1,3 @@
-{% load url from future %}
-
 <script src="{% static "forms/js/bundle.js" %}"></script>
 
 <script>

omero_forms/urls.py

@@ -1,82 +1,70 @@
-from django.conf.urls import url, patterns
-
+from django.conf.urls import url
 from . import views
 
-urlpatterns = patterns(
-    'django.views.generic.simple',
-
+urlpatterns = [
     # Designer App
-    url(r'^designer/$',
-        views.designer,
-        name='omeroforms_designer'),
-
+    url(r"^designer/$", views.designer, name="omeroforms_designer"),
     # API
-    url(r'^$',
-        lambda x: None,
-        name='omeroforms_base'),
-
+    url(r"^$", lambda x: None, name="omeroforms_base"),
     # List all forms
-    url(r'^list_forms/$',
-        views.list_forms,
-        name='omeroforms_list_forms'),
-
+    url(r"^list_forms/$", views.list_forms, name="omeroforms_list_forms"),
     # List the forms that are assigned to the user's active group that
     # apply to the object type
-    url(r'^list_applicable_forms/(?P<obj_type>\w+)/$',
+    url(
+        r"^list_applicable_forms/(?P<obj_type>\w+)/$",
         views.list_applicable_forms,
-        name='omeroforms_list_applicable_forms'),
-
+        name="omeroforms_list_applicable_forms",
+    ),
     # Get a form (latest version)
-    url(r'^get_form/(?P<form_id>[\w ]+)/$',
-        views.get_form,
-        name='omeroforms_get_form'),
-
+    url(r"^get_form/(?P<form_id>[\w ]+)/$", views.get_form, name="omeroforms_get_form"),
     # Get data for a form (latest version) for a certain object
-    url(r'^get_form_data/'
-        r'(?P<form_id>[\w ]+)/(?P<obj_type>\w+)/(?P<obj_id>[\w ]+)/$',
+    url(
+        r"^get_form_data/"
+        r"(?P<form_id>[\w ]+)/(?P<obj_type>\w+)/(?P<obj_id>[\w ]+)/$",
         views.get_form_data,
-        name='omeroforms_get_form_data'),
-
+        name="omeroforms_get_form_data",
+    ),
     # Get assignments (restricted to those the user can unassign)
-    url(r'get_form_assignments/$',
+    url(
+        r"get_form_assignments/$",
         views.get_form_assignments,
-        name='omeroforms_get_form_assignments'),
-
+        name="omeroforms_get_form_assignments",
+    ),
     # Get the entire history of a form including all data and the forms used
     # to enter that data
-    url(r'^get_form_data_history/'
-        r'(?P<form_id>[\w ]+)/(?P<obj_type>\w+)/(?P<obj_id>[\w ]+)/$',
+    url(
+        r"^get_form_data_history/"
+        r"(?P<form_id>[\w ]+)/(?P<obj_type>\w+)/(?P<obj_id>[\w ]+)/$",
         views.get_form_data_history,
-        name='omeroforms_get_form_data_history'),
-
+        name="omeroforms_get_form_data_history",
+    ),
     # Get groups that the user can manage
-    url(r'^get_managed_groups/$',
+    url(
+        r"^get_managed_groups/$",
         views.get_managed_groups,
-        name='omeroforms_get_managed_groups'),
-
+        name="omeroforms_get_managed_groups",
+    ),
     # Lookup usernames by uid
-    url(r'^get_users/$',
-        views.get_users,
-        name='omeroforms_get_users'),
-
+    url(r"^get_users/$", views.get_users, name="omeroforms_get_users"),
     # Check form id ownership
-    url(r'^get_formid_editable/(?P<form_id>[\w ]+)/$',
+    url(
+        r"^get_formid_editable/(?P<form_id>[\w ]+)/$",
         views.get_formid_editable,
-        name='omeroforms_get_formid_editable'),
-
+        name="omeroforms_get_formid_editable",
+    ),
     # Save a form version (potentially a new form)
-    url(r'^save_form/$',
-        views.save_form,
-        name='omeroforms_save_form'),
-
+    url(r"^save_form/$", views.save_form, name="omeroforms_save_form"),
     # Save data for a form
-    url(r'^save_form_data/'
-        r'(?P<form_id>[\w ]+)/(?P<obj_type>\w+)/(?P<obj_id>[\w ]+)/$',
+    url(
+        r"^save_form_data/"
+        r"(?P<form_id>[\w ]+)/(?P<obj_type>\w+)/(?P<obj_id>[\w ]+)/$",
         views.save_form_data,
-        name='omeroforms_save_form_data'),
-
+        name="omeroforms_save_form_data",
+    ),
     # Save a form assignment
-    url(r'^save_form_assignment/$',
+    url(
+        r"^save_form_assignment/$",
         views.save_form_assignment,
-        name='omeroforms_save_form_assignment'),
-)
+        name="omeroforms_save_form_assignment",
+    ),
+]