Use singleton EventLoopGroupProvider instead of createNew (#584)

Author: adam-fowler

Package.swift

@@ -29,7 +29,7 @@ let package = Package(
         .package(url: "https://github.com/apple/swift-nio.git", from: "2.42.0"),
         .package(url: "https://github.com/apple/swift-nio-ssl.git", from: "2.7.2"),
         .package(url: "https://github.com/apple/swift-nio-transport-services.git", from: "1.13.1"),
-        .package(url: "https://github.com/swift-server/async-http-client.git", from: "1.18.0"),
+        .package(url: "https://github.com/swift-server/async-http-client.git", from: "1.19.0"),
         .package(url: "https://github.com/adam-fowler/jmespath.swift.git", from: "1.0.2"),
     ],
     targets: [

Sources/SotoCore/AWSClient.swift

@@ -85,7 +85,7 @@ public final class AWSClient {
         case .createNewWithEventLoopGroup(let elg):
             self.httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .shared(elg), configuration: .init(timeout: .init(connect: .seconds(10))))
         case .createNew:
-            self.httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .createNew, configuration: .init(timeout: .init(connect: .seconds(10))))
+            self.httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .singleton, configuration: .init(timeout: .init(connect: .seconds(10))))
         }
 
         self.credentialProvider = credentialProviderFactory.createProvider(context: .init(

Tests/SotoCoreTests/AWSClientTests+async.swift

@@ -196,7 +196,7 @@ final class AWSClientAsyncTests: XCTestCase {
         guard ProcessInfo.processInfo.environment["CI"] == nil else { return }
         #endif
         let awsServer = AWSTestServer(serviceProtocol: .json)
-        let httpClient = HTTPClient(eventLoopGroupProvider: .createNew)
+        let httpClient = HTTPClient(eventLoopGroupProvider: .singleton)
         let config = createServiceConfig(endpoint: awsServer.address)
         let client = createAWSClient(credentialProvider: .empty, httpClientProvider: .shared(httpClient))
         defer {
@@ -211,7 +211,7 @@ final class AWSClientAsyncTests: XCTestCase {
     }
 
     func testShutdown() async throws {
-        let httpClient = HTTPClient(eventLoopGroupProvider: .createNew)
+        let httpClient = HTTPClient(eventLoopGroupProvider: .singleton)
 
         let client = createAWSClient(httpClientProvider: .shared(httpClient))
         try await client.shutdown()

Tests/SotoCoreTests/AWSClientTests.swift

@@ -60,7 +60,7 @@ class AWSClientTests: XCTestCase {
     }
 
     func testShutdown() {
-        let httpClient = HTTPClient(eventLoopGroupProvider: .createNew)
+        let httpClient = HTTPClient(eventLoopGroupProvider: .singleton)
         defer { XCTAssertNoThrow(try httpClient.syncShutdown()) }
 
         let client = createAWSClient(httpClientProvider: .shared(httpClient))
@@ -265,7 +265,7 @@ class AWSClientTests: XCTestCase {
 
     func testRequestStreaming() {
         let awsServer = AWSTestServer(serviceProtocol: .json)
-        let httpClient = HTTPClient(eventLoopGroupProvider: .createNew)
+        let httpClient = HTTPClient(eventLoopGroupProvider: .singleton)
         let config = createServiceConfig(endpoint: awsServer.address)
         let client = createAWSClient(credentialProvider: .empty, httpClientProvider: .shared(httpClient))
         defer {
@@ -281,7 +281,7 @@ class AWSClientTests: XCTestCase {
 
     func testRequestS3Streaming() {
         let awsServer = AWSTestServer(serviceProtocol: .json)
-        let httpClient = HTTPClient(eventLoopGroupProvider: .createNew)
+        let httpClient = HTTPClient(eventLoopGroupProvider: .singleton)
         let config = createServiceConfig(service: "s3", endpoint: awsServer.address)
         let client = createAWSClient(credentialProvider: .static(accessKeyId: "foo", secretAccessKey: "bar"), httpClientProvider: .shared(httpClient))
         defer {
@@ -303,7 +303,7 @@ class AWSClientTests: XCTestCase {
 
     func testRequestStreamingAvoidStackOverflow() {
         let awsServer = AWSTestServer(serviceProtocol: .json)
-        let httpClient = HTTPClient(eventLoopGroupProvider: .createNew)
+        let httpClient = HTTPClient(eventLoopGroupProvider: .singleton)
         let config = createServiceConfig(service: "s3", endpoint: awsServer.address)
         let client = createAWSClient(credentialProvider: .static(accessKeyId: "foo", secretAccessKey: "bar"), httpClientProvider: .shared(httpClient))
         defer {
@@ -324,7 +324,7 @@ class AWSClientTests: XCTestCase {
         }
 
         let awsServer = AWSTestServer(serviceProtocol: .json)
-        let httpClient = HTTPClient(eventLoopGroupProvider: .createNew)
+        let httpClient = HTTPClient(eventLoopGroupProvider: .singleton)
         let config = createServiceConfig(endpoint: awsServer.address)
         let client = createAWSClient(credentialProvider: .empty, httpClientProvider: .shared(httpClient))
         defer {
@@ -380,7 +380,7 @@ class AWSClientTests: XCTestCase {
         }
 
         let awsServer = AWSTestServer(serviceProtocol: .json)
-        let httpClient = HTTPClient(eventLoopGroupProvider: .createNew)
+        let httpClient = HTTPClient(eventLoopGroupProvider: .singleton)
         let config = createServiceConfig(endpoint: awsServer.address)
         let client = createAWSClient(credentialProvider: .empty, httpClientProvider: .shared(httpClient))
         defer {
@@ -435,7 +435,7 @@ class AWSClientTests: XCTestCase {
         }
 
         let awsServer = AWSTestServer(serviceProtocol: .json)
-        let httpClient = HTTPClient(eventLoopGroupProvider: .createNew)
+        let httpClient = HTTPClient(eventLoopGroupProvider: .singleton)
         let config = createServiceConfig(endpoint: awsServer.address)
         let client = createAWSClient(credentialProvider: .empty, httpClientProvider: .shared(httpClient))
         defer {
@@ -481,7 +481,7 @@ class AWSClientTests: XCTestCase {
             // provides it to AWSClient
             let awsServer = AWSTestServer(serviceProtocol: .json)
             let httpClientConfig = AsyncHTTPClient.HTTPClient.Configuration(redirectConfiguration: .init(.disallow))
-            let httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .createNew, configuration: httpClientConfig)
+            let httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .singleton, configuration: httpClientConfig)
             let config = createServiceConfig(serviceProtocol: .json(version: "1.1"), endpoint: awsServer.address)
             let client = createAWSClient(credentialProvider: .empty, httpClientProvider: .shared(httpClient))
             defer {
@@ -507,7 +507,7 @@ class AWSClientTests: XCTestCase {
 
     func testServerError() {
         do {
-            let httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .createNew)
+            let httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .singleton)
             let awsServer = AWSTestServer(serviceProtocol: .json)
             let config = createServiceConfig(serviceProtocol: .json(version: "1.1"), endpoint: awsServer.address)
             let client = createAWSClient(credentialProvider: .empty, retryPolicy: .exponential(base: .milliseconds(200)), httpClientProvider: .shared(httpClient))
@@ -546,7 +546,7 @@ class AWSClientTests: XCTestCase {
             let s: String
         }
         do {
-            let httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .createNew)
+            let httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .singleton)
             let awsServer = AWSTestServer(serviceProtocol: .json)
             let config = createServiceConfig(serviceProtocol: .json(version: "1.1"), endpoint: awsServer.address)
             let client = createAWSClient(credentialProvider: .empty, retryPolicy: .jitter(), httpClientProvider: .shared(httpClient))
@@ -640,7 +640,7 @@ class AWSClientTests: XCTestCase {
             let s: String
         }
         do {
-            let httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .createNew)
+            let httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .singleton)
             let awsServer = AWSTestServer(serviceProtocol: .json)
             let config = createServiceConfig(serviceProtocol: .json(version: "1.1"), endpoint: awsServer.address)
             let client = createAWSClient(credentialProvider: .empty, retryPolicy: .jitter(), httpClientProvider: .shared(httpClient))
@@ -687,7 +687,7 @@ class AWSClientTests: XCTestCase {
         }
         let retryPolicy = TestRetryPolicy()
         do {
-            let httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .createNew)
+            let httpClient = AsyncHTTPClient.HTTPClient(eventLoopGroupProvider: .singleton)
             let awsServer = AWSTestServer(serviceProtocol: .json)
             let config = createServiceConfig(serviceProtocol: .json(version: "1.1"), endpoint: awsServer.address)
             let client = createAWSClient(credentialProvider: .empty, retryPolicy: .init(retryPolicy: retryPolicy), httpClientProvider: .shared(httpClient))

Tests/SotoCoreTests/Credential/ConfigFileCredentialProviderTests.swift

@@ -238,7 +238,7 @@ class ConfigFileCredentialProviderTests: XCTestCase {
         // Prepare test server and AWS client
         let testServer = AWSTestServer(serviceProtocol: .xml)
         defer { XCTAssertNoThrow(try testServer.stop()) }
-        let httpClient = HTTPClient(eventLoopGroupProvider: .createNew)
+        let httpClient = HTTPClient(eventLoopGroupProvider: .singleton)
         defer { XCTAssertNoThrow(try httpClient.syncShutdown()) }
 
         // Here we use `.custom` provider factory, since we need to inject the testServer endpoint