From 27741bbfca1d6b4c1349b2e8ed53bd4f03e72e56 Mon Sep 17 00:00:00 2001 From: He Jie Xu Date: Thu, 23 Nov 2023 06:41:15 +0000 Subject: [PATCH] cleanup Signed-off-by: He Jie Xu --- source/common/io/io_uring_worker_impl.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/source/common/io/io_uring_worker_impl.cc b/source/common/io/io_uring_worker_impl.cc index 09fd10769be6..cfd75d994764 100644 --- a/source/common/io/io_uring_worker_impl.cc +++ b/source/common/io/io_uring_worker_impl.cc @@ -475,8 +475,6 @@ void IoUringServerSocket::onRead(Request* req, int32_t result, bool injected) { } // If `enable_close_event_` is true, then deliver the remote close as close event. - // TODO (soulxu): Add test for the case the status is enabled, but listen on the closed - // event. This case is used for listener filter. if (read_error_.has_value() && read_error_ == 0) { if (enable_close_event_) { ENVOY_LOG(trace, @@ -491,8 +489,6 @@ void IoUringServerSocket::onRead(Request* req, int32_t result, bool injected) { // In this case, the closed event isn't listened and the status is disabled. // It means we can't raise the closed or read event. So we only can raise the // write event. - // TODO (soulxu): We should try to move this logic to the - // `IoUringSocketHandle::onRemoteClose()`. ENVOY_LOG(trace, "remote closed and close event disabled, raise the write event, fd = " "{}, result = {}",