Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory iterator.Seek probably needs to return to previous location on failed Seek #23

Open
AndrewSisley opened this issue Jan 21, 2025 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@AndrewSisley
Copy link
Collaborator

If a failed Seek is performed, e.g. to an out of bounds value, it probably needs to reset to it's prior state and return false.

I am unsure if we have any tests yet for this, make sure the memory store behaviour matches badger.

It might be that this doesn't really make sense or can be postponed with our interface.

Spotted by Fred.

@AndrewSisley AndrewSisley added the bug Something isn't working label Jan 21, 2025
@AndrewSisley AndrewSisley added this to the CoreKV v0.1 milestone Jan 21, 2025
@AndrewSisley AndrewSisley self-assigned this Jan 21, 2025
@AndrewSisley AndrewSisley removed their assignment Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant