Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory.Close closes transactions but Badger.Close does not #39

Open
AndrewSisley opened this issue Jan 24, 2025 · 0 comments
Open

Memory.Close closes transactions but Badger.Close does not #39

AndrewSisley opened this issue Jan 24, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@AndrewSisley
Copy link
Collaborator

AndrewSisley commented Jan 24, 2025 •
edited
Loading

I think, reading both implementations (including badger-raw internals). Both are untested.

Same applies to iterators - memory closes them, but badger does not.

This issue is noted in the documentation for Store.Close, please update the documentation when resolving this issue.
@AndrewSisley AndrewSisley added the bug Something isn't working label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndrewSisley