Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auth proxy issues by disabling caching for non-static files #584

Closed
1 task done
richardtreier opened this issue Dec 22, 2023 · 2 comments · Fixed by #632
Closed
1 task done

fix auth proxy issues by disabling caching for non-static files #584

richardtreier opened this issue Dec 22, 2023 · 2 comments · Fixed by #632
Assignees
Labels
good first issue Good for newcomers kind/enhancement New feature or request status/blocked/needs-info requires more information in order to be completed

Comments

@richardtreier
Copy link
Collaborator

richardtreier commented Dec 22, 2023

Feature Request

Description

As a user,
I want the system to properly handle page caching during logout,
So that I do not encounter a broken page due to the browser skipping the request.

How does this tie into our current product?

This error occurs because the browsers cached the page, skipping the request, which would otherwise redirect to a keycloak browser flow.

We have an auth proxy for this otherwise unprotected UI image.

This request focuses on improving the user experience during logout and ensuring the security of the UI image.

Acceptance Criteria

  • When user logs out, the system should invalidate the cache and redirect user to the keycloak browser flow.
  • The system should ensure the UI image is protected via an auth proxy. @kulgg @richardtreier please validate if this is a valid acceptance criteria to keep.
  • Implement solution across all variants of the CaaS.

Solution Proposal and Work Breakdown

The solution is to add the same thing we added for the authority portal in the EDC CE.

Tasks

@AbdullahMuk @kulgg

@richardtreier richardtreier added good first issue Good for newcomers kind/enhancement New feature or request labels Dec 22, 2023
@richardtreier richardtreier changed the title Fix some auth issues by disabling caching for non-static files fix auth proxy issues by disabling caching for non-static files Dec 22, 2023
@kulgg
Copy link
Collaborator

kulgg commented Jan 3, 2024

I discovered another bug while working on this issue: #591
The /logout page does not work during local development (unrelated to nginx)

@AbdullahMuk AbdullahMuk added the status/blocked/needs-info requires more information in order to be completed label Jan 3, 2024
@kulgg
Copy link
Collaborator

kulgg commented Jan 3, 2024

This issue might be a misdiagnosis.
In the staging the environment the blank page is caused by the same NullInjectionError.
Here, the o probably refers to PreviousRouteListener (JS minimization in prod).

core.mjs:9171 ERROR Error: Uncaught (in promise): NullInjectorError: R3InjectorError(o)[o -> o -> o -> o -> o]: 
  NullInjectorError: No provider for o!

@AbdullahMuk AbdullahMuk added next-sprint Potentially carry forward to next sprint and removed next-sprint Potentially carry forward to next sprint labels Jan 8, 2024
@kulgg kulgg linked a pull request Jan 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement New feature or request status/blocked/needs-info requires more information in order to be completed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants