Style docker files consistently

[ivanperez-keera]

I just noticed that docker files are not indented very consistently. For example, here the && start a column zero:

docker/space_robots/Dockerfile

Lines 81 to 83 in 76cd412

	&& /bin/bash -c 'source "${SPACEROS_DIR}/install/setup.bash"' \
	&& /bin/bash -c 'source "${MOVEIT2_DIR}/install/setup.bash"' \
	&& rosdep install --from-paths src --ignore-src -r -y --rosdistro ${ROSDISTRO}

but just a little bit later, they start at column 2:

docker/space_robots/Dockerfile

Line 87 in 76cd412

&& colcon build --cmake-args -DCMAKE_BUILD_TYPE=Release'

I've always found that keeping a consistent style helps catch errors and propagate updates.

The following extra vertical space is not needed (and double space is not used elsewhere):

docker/space_robots/Dockerfile

Line 65 in 76cd412

The following invocations of apt-get passes the argument -y last:

docker/space_robots/Dockerfile

Line 67 in 76cd412

RUN sudo apt install libmongoc-dev -y

docker/space_robots/Dockerfile

Line 70 in 76cd412

RUN sudo apt install libssl-dev build-essential devscripts debian-keyring fakeroot debhelper cmake libboost-dev libsasl2-dev libicu-dev libzstd-dev doxygen -y

Others pass it first:

docker/space_robots/Dockerfile

Line 47 in 76cd412

RUN sudo apt-get update -y && sudo apt-get install -y python3-rosinstall-generator

IMO the latter is preferable because it conveys the important information sooner and is less likely to be removed by mistake.