Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust READMEs and Apply Fixes for Demos Base Images #161

Open
eholum opened this issue Aug 11, 2024 · 2 comments · May be fixed by #189
Open

Adjust READMEs and Apply Fixes for Demos Base Images #161

eholum opened this issue Aug 11, 2024 · 2 comments · May be fixed by #189
Milestone
jazzy-2024.10.0

Comments

@eholum
Copy link
Contributor

eholum commented Aug 11, 2024

We need to update a handful of references in the README and demo build files to handle folder moves and other changes from space-ros/space-ros#177, including those pushed in space-ros/space-ros#170.

There are still a few hard coded ~/spaceros lying around, and we standardized some env variables (ROS_DISTRO instead of ROSDISTRO).
eholum added a commit to eholum/docker that referenced this issue Aug 11, 2024
@eholum
Remove reference to spaceros dir in home directory (issue space-ros#161)
0089740
eholum added a commit to eholum/docker that referenced this issue Aug 11, 2024
@eholum
Replace ROSDISTRO with ROS_DISTRO (issue space-ros#161)
ba66a53
eholum added a commit to eholum/docker that referenced this issue Aug 11, 2024
@eholum
Do not install rosdeps from non-existent src in moveit2 build (issue s…
a8ccdb1 
…pace-ros#161)
@eholum eholum mentioned this issue Aug 11, 2024
Closed
@martincerven
Copy link

Bump, wanted to try docker images as part of NASA Space ROS Sim Summer Sprint Challenge, only to find out you refactored a LOT just weeks ago and repo is currently in broken state, but looks like #162 fixes these ENV mismatches.

@eholum
Copy link
Contributor Author

eholum commented Aug 19, 2024

@martincerven Yep, sorry about that. The timing of taking on some significant reworking of our packaging + the challenge could definitely have been better.

If you want to move forward with either the latest release or the fix on main you can follow the instructions in #160 (comment).

@Bckempa Bckempa added this to the jazzy-2024.10.0 milestone Aug 22, 2024
@eholum eholum changed the title Adjust READMEs and Demos Updated Base Image Adjust READMEs and Apply Fixes for Demos Base Images Aug 22, 2024
@Bckempa Bckempa mentioned this issue Sep 9, 2024
Closed
eholum added a commit that referenced this issue Sep 19, 2024
@eholum
Remove reference to spaceros dir in home directory (issue #161)
63687ed
eholum added a commit that referenced this issue Sep 19, 2024
@eholum
Replace ROSDISTRO with ROS_DISTRO (issue #161)
88b19c2
eholum added a commit that referenced this issue Sep 19, 2024
@eholum
Do not install rosdeps from non-existent src in moveit2 build (issue #…
abf83e4 
…161)
eholum added a commit that referenced this issue Sep 19, 2024
@eholum
Parameterize base image name for the MoveIt2 build (issue #161)
1651588
@eholum eholum linked a pull request Sep 19, 2024 that will close this issue
Open
eholum added a commit that referenced this issue Sep 19, 2024
@eholum
Parameterize base image name for the MoveIt2 build (issue #161)
fc0482c
eholum added a commit that referenced this issue Sep 24, 2024
@eholum
Parameterize base image name for the MoveIt2 build (issue #161)
b551008
eholum added a commit that referenced this issue Sep 24, 2024
@eholum
Parameterize base image name for the nav2 build (issue #161)
bd6de91
eholum added a commit that referenced this issue Sep 24, 2024
@eholum
Use osrf/space-ros:main image for base in CI (issue #161)
c8ae621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Space ROS Project Development
Status: In Progress
Milestone
jazzy-2024.10.0
3 participants
@Bckempa @eholum @martincerven