You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This could be a breaking change for some of the other issues but it should help will growing stacks for the project.
Implementation considerations
The key changes in the above proposal:
The space_robots directory related to the demos have been removed.
The build.sh and run.sh has been moved to root of the repository. This will allow stack images which doesn't need special process like the GUI variant as mentioned in Build docker variant for GUI apps #188. This change is subtle and likely can be skipped if necessary.
The build and run context of the stack images could be something like this,
# To build nav2 image for example,
docker build -t osrf/space-ros:nav2 -f Dockerfile.nav2 navigation2
This is not the complete proposed structure yet and might get updated soon before working on this.
The text was updated successfully, but these errors were encountered:
One of the ACO goals was to showcase Space ROS in use on various platforms (meaning hardware and software) relevant to spaceflight applications. These docker images supported that effort. You can see the specific goals of each of those in their respective readmes.
Feature description
We are moving few contents of the
docker
repository to the demos repository as a part of space-ros/space-ros#178.This will require the current structure to be updated to the new format and I am proposing new directory structure.
The soon to be
stacks
repository can be of the format as described below.This could be a breaking change for some of the other issues but it should help will growing stacks for the project.
Implementation considerations
The key changes in the above proposal:
space_robots
directory related to the demos have been removed.build.sh
andrun.sh
has been moved to root of the repository. This will allow stack images which doesn't need special process like the GUI variant as mentioned in Build docker variant for GUI apps #188. This change is subtle and likely can be skipped if necessary.# To build nav2 image for example, docker build -t osrf/space-ros:nav2 -f Dockerfile.nav2 navigation2
The text was updated successfully, but these errors were encountered: