Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match results across SARIF files #2

Open
Ronoman opened this issue Aug 9, 2022 · 1 comment
Open

Match results across SARIF files #2

Ronoman opened this issue Aug 9, 2022 · 1 comment

Comments

@Ronoman
Copy link
Contributor

Ronoman commented Aug 9, 2022

Currently, duplicate Results within a single SarifFile are excluded from the SarifFile objects created by sarif.py. Results that are duplicated across SARIF files are not currently checked.

To implement:

  1. Compare results that match the same Artifact and Region (line+Optional[column] numbers).
    a. If they match the same ruleId, report and discard one (which?)
    b. If they don't, we should inspect and determine whether they report the same issue. If they do, create a grouping that correlates those rules with each other.
@Ronoman
Copy link
Contributor Author

Ronoman commented Aug 12, 2022 •
edited
Loading

This is now partially implemented in sarif_helpers:find_duplicate_results. However, ruleId is not checked, only matching Artifact and Region fields for Results.

@mjeronimo mjeronimo changed the title Match Results across SarifFiles Match results across SARIF files May 16, 2023
@mjeronimo mjeronimo added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels May 16, 2023
@Bckempa Bckempa mentioned this issue Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Space ROS Project Development
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjeronimo @Ronoman