From 2c0b40e0e5c589baf15f4a5f5de907e8230b52f4 Mon Sep 17 00:00:00 2001 From: manuel <9112949+CampelloManuel@users.noreply.github.com> Date: Mon, 5 Dec 2022 15:45:45 +0100 Subject: [PATCH] add log calls to investigate crashes --- .github/workflows/android_tests.yml | 8 +++++--- .../notepad/sync/orgsync/OrgSyncService.java | 16 ++++++++-------- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/.github/workflows/android_tests.yml b/.github/workflows/android_tests.yml index ef0f030a7..d95fe639c 100644 --- a/.github/workflows/android_tests.yml +++ b/.github/workflows/android_tests.yml @@ -75,8 +75,9 @@ jobs: disk-size: 500M # needed for saving org and json files force-avd-creation: false # it's picky on the parameters - emulator-options: -no-boot-anim -no-window -accel on # -gpu host + emulator-options: -no-boot-anim -no-window disable-animations: true + disable-spellchecker: true # starts the emulator, runs this script, then closes the emulator script: | # wait for it to finish booting, then take a screenshot @@ -106,8 +107,9 @@ jobs: disk-size: 500M force-avd-creation: false disable-animations: true - # -gpu swiftshader_indirect - emulator-options: -no-snapshot-save -verbose -no-boot-anim -no-window + disable-spellchecker: true + # TODO test -gpu host + emulator-options: -no-snapshot-save -verbose -no-boot-anim -no-window -accel on # -gpu host script: bash ./github_on_emu_started.sh - name: upload the generated files diff --git a/app/src/main/java/com/nononsenseapps/notepad/sync/orgsync/OrgSyncService.java b/app/src/main/java/com/nononsenseapps/notepad/sync/orgsync/OrgSyncService.java index afe665cb5..02ee73ff8 100644 --- a/app/src/main/java/com/nononsenseapps/notepad/sync/orgsync/OrgSyncService.java +++ b/app/src/main/java/com/nononsenseapps/notepad/sync/orgsync/OrgSyncService.java @@ -17,33 +17,25 @@ package com.nononsenseapps.notepad.sync.orgsync; -import android.app.Notification; -import android.app.NotificationManager; -import android.app.PendingIntent; import android.app.Service; import android.content.Context; import android.content.Intent; import android.content.SharedPreferences; import android.database.ContentObserver; import android.net.Uri; -import android.os.Build; import android.os.Handler; import android.os.HandlerThread; import android.os.IBinder; import android.os.Looper; import android.os.Message; import android.os.Process; -import android.util.Log; -import androidx.core.app.NotificationCompat; import androidx.preference.PreferenceManager; import com.nononsenseapps.helpers.NnnLogger; -import com.nononsenseapps.helpers.NotificationHelper; import com.nononsenseapps.notepad.BuildConfig; import com.nononsenseapps.notepad.database.Task; import com.nononsenseapps.notepad.database.TaskList; -import com.nononsenseapps.notepad.prefs.PrefsActivity; import com.nononsenseapps.notepad.prefs.SyncPrefs; import com.nononsenseapps.notepad.sync.SyncAdapter; @@ -70,17 +62,25 @@ public class OrgSyncService extends Service { private final ArrayList synchronizers; public static void start(Context context) { + NnnLogger.debug(OrgSyncService.class, "got here #1"); context.startService(new Intent(context, OrgSyncService.class) // TODO startservice. does this work correctly in newer android versions ? .setAction(ACTION_START)); + NnnLogger.debug(OrgSyncService.class, "got here #2"); } + // TODO this service crashes in API 23 - default image on github + public static void pause(Context context) { + NnnLogger.debug(OrgSyncService.class, "got here #3"); context.startService(new Intent(context, OrgSyncService.class) // TODO startservice. does this work correctly in newer android versions ? .setAction(ACTION_PAUSE)); + NnnLogger.debug(OrgSyncService.class, "got here #4"); } public static void stop(Context context) { + NnnLogger.debug(OrgSyncService.class, "got here #5"); context.stopService(new Intent(context, OrgSyncService.class)); + NnnLogger.debug(OrgSyncService.class, "got here #6"); } public static boolean areAnyEnabled(Context context) {