Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying products by name not just section #81

Open
jtniehof opened this issue May 21, 2021 · 0 comments
Open

Support specifying products by name not just section #81

jtniehof opened this issue May 21, 2021 · 0 comments
Labels
enhancement New feature or feature request

Comments

@jtniehof
Copy link
Member

addFromConfig works from a config file. Each process and product has a section in the config file, headed by a section name in []. The "type" of section is determined by the section name, so [product_rot13] is a product. The process sections need to specify the inputs (optional and required) and the output product.

The section name is not stored in the database. Each product also has a product_name, which is stored in the db.

Right now the input and output products are specified by section name, not product name. It would be convenient to allow specifying by product name as well. This might also make it easier to have a "partial" config file that adds processes to an existing database.

Relation to an issue

Relevant to discussion in #78, which had to make changes to configFromDB to work around this limitation.

Proposed enhancement

This config file illustrates the difference. It doesn't successfully run through addFromConfig as it uses product names. Lines referencing the section names are included (commented out).
product_names.conf.txt

Alternatives

Documentation is probably the best alternative (and needs to happen anyhow). Right now the only documentation is in a comment block at the head of configFromDB, and it implies product name can be used for inputs (but not for output.)

OS, Python version, and dependency version information:

Linux-4.15.0-143-generic-x86_64-with-Ubuntu-18.04-bionic
sys.version_info(major=2, minor=7, micro=17, releaselevel='final', serial=0)
sqlalchemy=1.1.11

Version of dbprocessing

Branch from #78

Closure condition

This issue should be closed when the attached file can be ingested with addFromConfig, and appropriate unit tests are included to verify this.

@jtniehof jtniehof added the enhancement New feature or feature request label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or feature request
Projects
None yet
Development

No branches or pull requests

1 participant