use tmp_path in tests that create temporary files

Author: zacharyburnett

tests/test_airglow.py

@@ -3,7 +3,7 @@
 import os
 
 
-def test_find_airglow_limits():
+def test_find_airglow_limits(tmp_path):
     """
     unit test for find_airglow_limits()
     test ran
@@ -20,13 +20,23 @@ def test_find_airglow_limits():
 
     """
     # Setup
-    inf = {"obstype": "SPECTROSCOPIC", "cenwave": 1055, "aperture": "PSA", "detector": "FUV",
-           "opt_elem": "G130M", "segment": "FUVA"}
+    inf = {
+        "obstype": "SPECTROSCOPIC",
+        "cenwave": 1055,
+        "aperture": "PSA",
+        "detector": "FUV",
+        "opt_elem": "G130M",
+        "segment": "FUVA",
+    }
     seg = ["FUVA", "FUVB"]
-    disptab = create_disptab_file('49g17153l_disp.fits')
+    disptab = create_disptab_file(str(tmp_path / "49g17153l_disp.fits"))
     airglow_lines = ["Lyman_alpha", "N_I_1200", "O_I_1304", "O_I_1356", "N_I_1134"]
     actual_pxl = [
-        [], [], (15421.504705213156, 15738.02214190493), (8853.838672375898, 9135.702216258482)]
+        [],
+        [],
+        (15421.504705213156, 15738.02214190493),
+        (8853.838672375898, 9135.702216258482),
+    ]
     # Test
     test_pxl = [[], []]
     # only works for FUV
@@ -39,6 +49,3 @@ def test_find_airglow_limits():
     # Verify
     for i in range(len(actual_pxl)):
         assert actual_pxl[i] == test_pxl[i]
-
-    # Cleanup
-    os.remove(disptab)

tests/test_average.py

@@ -7,7 +7,7 @@
 from generate_tempfiles import create_count_file
 
 
-def test_avg_image():
+def test_avg_image(tmp_path):
     """
     tests avg_image() in average.py
     explanation of the test
@@ -19,10 +19,8 @@ def test_avg_image():
     pass if expected == actual fail otherwise.
     """
     # Setup
-    infile = ["test_count1.fits", "test_count2.fits"]
-    outfile = "test_output.fits"
-    if os.path.exists(outfile):
-        os.remove(outfile)  # avoid file exists error
+    infile = [str(tmp_path / "test_count1.fits"), str(tmp_path / "test_count2.fits")]
+    outfile = str(tmp_path / "test_output.fits")
     create_count_file(infile[0])
     create_count_file(infile[1])
     inhdr1, inhdr2 = fits.open(infile[0]), fits.open(infile[1])
@@ -32,11 +30,8 @@ def test_avg_image():
 
     # Verify
     assert os.path.exists(outfile)
-    for (i, j, k) in zip(inhdr1[1].header, inhdr2[1].header, out_hdr[1].header):
+    for i, j, k in zip(inhdr1[1].header, inhdr2[1].header, out_hdr[1].header):
         assert i == j == k
-    np.testing.assert_array_equal((inhdr1[1].data + inhdr1[1].data) / 2, out_hdr[1].data)
-
-    # Cleanup
-    for tempfile in infile:
-        os.remove(tempfile)
-    os.remove(outfile)
+    np.testing.assert_array_equal(
+        (inhdr1[1].data + inhdr1[1].data) / 2, out_hdr[1].data
+    )