Skip to content

Commit d3f69b4

Browse files
committed
implementing suggestions of reviewer
1 parent af4aedd commit d3f69b4

File tree

3 files changed

+71
-97
lines changed

3 files changed

+71
-97
lines changed

notebooks/cross_instrument/update_pure_parallel_wcs/NIRISS_correct_pure_parallel_WCS.ipynb

Lines changed: 60 additions & 87 deletions
Large diffs are not rendered by default.

notebooks/cross_instrument/update_pure_parallel_wcs/requirements.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@ numpy>=1.25.2
22
astropy>=5.3.4
33
jwst>=1.15.1
44
matplotlib>=3.8.0
5-
pysiaf>=0.22.0
6-
mastquery>=1.7.1
5+
pysiaf>=0.23.3
76
astroquery>=0.4.6

notebooks/cross_instrument/update_pure_parallel_wcs/update_parallel_wcs.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -120,14 +120,16 @@ def update_pure_parallel_wcs(file, logfile="pure_parallel_wcs_logfile",
120120

121121
crval_fix = par_aper.sci_to_sky(*crpix)
122122

123-
msg = f"PureParallelUtils.update_pure_parallel_wcs: File: {file}"
124-
msg += '\n' + f"PureParallelUtils.update_pure_parallel_wcs: FGS: {gs['fileName']} "
125-
msg += '\n' + "PureParallelUtils.update_pure_parallel_wcs: original crval "
126-
msg += f"{crval_init[0]:.7f} {crval_init[1]:.7f}"
127-
msg += '\n' + "PureParallelUtils.update_pure_parallel_wcs: new crval "
128-
msg += f"{crval_fix[0]:.7f} {crval_fix[1]:.7f}"
129-
msg += '\n' + "PureParallelUtils.update_pure_parallel_wcs: dpix "
130-
msg += f"{crpix[0] - crpix_init[0]:6.3f} {crpix[1] - crpix_init[1]:6.3f}"
123+
msg = (
124+
f"PureParallelUtils.update_pure_parallel_wcs: File: {file}\n"
125+
f"PureParallelUtils.update_pure_parallel_wcs: FGS: {gs['fileName']}\n"
126+
f"PureParallelUtils.update_pure_parallel_wcs: original crval: "
127+
f"{crval_init[0]:.7f} {crval_init[1]:.7f}\n"
128+
f"PureParallelUtils.update_pure_parallel_wcs: new crval: "
129+
f"{crval_fix[0]:.7f} {crval_fix[1]:.7f}\n"
130+
f"PureParallelUtils.update_pure_parallel_wcs: d(pix): "
131+
f"{crpix[0] - crpix_init[0]:6.3f} {crpix[1] - crpix_init[1]:6.3f}"
132+
)
131133

132134
_ = log_comment(logfile, msg, verbose=verbose)
133135

0 commit comments

Comments
 (0)