Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump Step should process all integrations at once #8300

Closed
stscijgbot-jp opened this issue Feb 21, 2024 · 4 comments · Fixed by spacetelescope/stcal#242
Closed

Jump Step should process all integrations at once #8300

stscijgbot-jp opened this issue Feb 21, 2024 · 4 comments · Fixed by spacetelescope/stcal#242

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3550 was created on JIRA by Michael Regan:

Currently, the Jump step separately searches for jumps in each integration. For integrations with a relatively small number of groups (~<6) the result can be that jumps will not be masked.  

  In the case where there are multiple integrations, the code should use all of the integrations at once to identify the jumps. 

  This issue is related to help desk ticket INC0190775.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

Fixed by spacetelescope/stcal#242

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

updates on the jwst side are in #8304

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Melanie Clarke on JIRA:

Testing these changes on data with a small number of groups, from INC0197753, seems to have improved jump detection significantly compared to v1.13.4.  The sinusoidal artifacts mentioned in the ticket are no longer present in the final extracted spectrum.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Closing based on my own testing and that by Melanie Clarke 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant