Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIRI Shower Improvements #8333

Closed
stscijgbot-jp opened this issue Mar 6, 2024 · 3 comments · Fixed by spacetelescope/stcal#248
Closed

MIRI Shower Improvements #8333

stscijgbot-jp opened this issue Mar 6, 2024 · 3 comments · Fixed by spacetelescope/stcal#248

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3562 was created on JIRA by Michael Regan:

The current MIR Shower flagging code as a couple of issues:

Reference pixels are treated the same as data pixels in the convolution used to detect showers. This can lead to false positive detections of showers.

The determination of the median value is not accurate for short integrations. The code should use all the integrations to determine the median difference of pixels.

Pixels that have DQ values of 5 (jump + DONOTUSE) or 6 (jump + saturation) are not masked before the convolution.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

Updates to the stcal side of things are in spacetelescope/stcal#248

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

jwst updates in #8303

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Already iterated with Michael Regan on testing this during development; looks good to me and improving the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant