Fix the broken tests

Author: WilliamJamieson

src/roman_datamodels/maker_utils/_datamodels.py

@@ -448,7 +448,9 @@ def mk_source_catalog(*, filepath=None, **kwargs):
     roman_datamodels.stnode.SourceCatalog
     """
     source_catalog = stnode.SourceCatalog()
-    source_catalog["meta"] = kwargs.get("meta", {})
-    source_catalog["source_catalog"] = kwargs.get("source_catalog", Table())
+    # There currently is no meta attribute for SourceCatalog
+    #   This is likely to change once metadata has been added
+    # source_catalog["meta"] = kwargs.get("meta", {})
+    source_catalog["source_catalog"] = kwargs.get("source_catalog", Table([range(3), range(3)], names=["a", "b"]))
 
     return save_node(source_catalog, filepath=filepath)

src/roman_datamodels/testing.py

@@ -2,6 +2,7 @@
 import numpy as np
 from asdf.tags.core import NDArrayType
 from astropy.modeling import Model
+from astropy.table import Table
 from numpy.testing import assert_array_equal
 
 from .stnode import DNode, TaggedListNode, TaggedObjectNode, TaggedScalarNode
@@ -57,6 +58,8 @@ def _assert_value_equal(value1, value2):
         assert_array_equal(value1, value2)
     elif isinstance(value1, Model):
         assert_model_equal(value1, value2)
+    elif isinstance(value1, Table):
+        assert (value1 == value2).all()
     elif isinstance(value1, gwcs.WCS):
         return True
     else:

tests/test_models.py

@@ -7,7 +7,7 @@
 from asdf.exceptions import ValidationError
 from astropy import units as u
 from astropy.modeling import Model
-from astropy.table import QTable
+from astropy.table import QTable, Table
 from numpy.testing import assert_array_equal
 
 from roman_datamodels import datamodels
@@ -707,6 +707,14 @@ def test_append_individual_image_meta_level3_mosaic():
     assert wfi_mosaic_model.meta.individual_image_meta.program["pi_name"][2] == "Roman"
 
 
+# source catalog tests
+def test_make_source_catalog():
+    source_catalog = utils.mk_source_catalog()
+    source_catalog_model = datamodels.SourceCatalogModel(source_catalog)
+
+    assert isinstance(source_catalog_model.source_catalog, Table)
+
+
 def test_datamodel_info_search(capsys):
     wfi_science_raw = utils.mk_level1_science_raw(shape=(2, 8, 8))
     af = asdf.AsdfFile()

tests/test_open.py

@@ -226,6 +226,9 @@ def test_node_round_trip(tmp_path, node_class):
 @pytest.mark.filterwarnings("ignore:This function assumes shape is 2D")
 @pytest.mark.filterwarnings("ignore:Input shape must be 5D")
 def test_opening_model(tmp_path, node_class):
+    if node_class == stnode.SourceCatalog:
+        pytest.xfail("SourceCatalog does not have a meta attribute yet")
+
     file_path = tmp_path / "test.asdf"
 
     # Create a node and write it to disk