Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model_type needs to be updated #1036

Closed
stscijgbot-rstdms opened this issue Dec 1, 2023 · 1 comment · Fixed by spacetelescope/roman_datamodels#296
Closed

model_type needs to be updated #1036

stscijgbot-rstdms opened this issue Dec 1, 2023 · 1 comment · Fixed by spacetelescope/roman_datamodels#296

Comments

@stscijgbot-rstdms
Copy link
Collaborator

stscijgbot-rstdms commented Dec 1, 2023

Issue RCAL-728 was created on JIRA by David Davis:

The attribute model_type should be updated when the underlying model is updated.

 

import roman_datamodels as rdm
>>> uncal1 = rdm.open('data/r0000101001001001001_01101_0001_WFI01_uncal.asdf')
type(uncal1)
<class 'roman_datamodels.datamodels._datamodels.ScienceRawModel'>
>>> uncal1.meta.model_type
'WfiScienceRaw'
result = DQInitStep.call(uncal1)
..
2023-12-01 09:38:12,091 - stpipe.DQInitStep - INFO - Step DQInitStep done
>>> type(result)
<class 'roman_datamodels.datamodels._datamodels.RampModel'>
>>> result.meta.model_type
'WfiScienceRaw'

So the model is updated but the attribute model_type remains WfiScienceRaw
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant