You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to the resample step input handling described in #1309 a more general reorganization of input handling could yield performance improvements and a more consistent step behavior for romancal.
Most steps being with a call to datamodels.open. For an input filename this will open the file (and return a datamodel). However for an already open datamodel this will create a shallow copy. However, the general convention in romancal is that steps modify their inputs.
The following changes could be considered:
change the datamodels.open call at the start of each step to self.open_model
update Step._datamodels_open to return the same model when called with an open model (this has the added benefit of allowing stpipe to open the input file fewer times and create fewer shallow copies)
document and test the established convention that steps modify inputs (with a few exceptions where the input model type is changed)
The text was updated successfully, but these errors were encountered:
Issue RCAL-875 was created on JIRA by Brett Graham:
Related to the resample step input handling described in #1309 a more general reorganization of input handling could yield performance improvements and a more consistent step behavior for romancal.
Most steps being with a call to
datamodels.open
. For an input filename this will open the file (and return a datamodel). However for an already open datamodel this will create a shallow copy. However, the general convention in romancal is that steps modify their inputs.The following changes could be considered:
datamodels.open
call at the start of each step toself.open_model
Step._datamodels_open
to return the same model when called with an open model (this has the added benefit of allowing stpipe to open the input file fewer times and create fewer shallow copies)The text was updated successfully, but these errors were encountered: