Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_level2_image_processing_pipeline and test_level2_grism_processing_pipeline lead to unexpected "okify" results #1325

Open
braingram opened this issue Jul 22, 2024 · 0 comments · May be fixed by #1426

Comments

@braingram
Copy link
Collaborator

The test_level2_image_processing_pipeline and test_level2_grism_processing_pipeline tests are very long, containing many asserts and more than 1 call to compare_asdf.

This is an issue for "okifying" results. For example, if test_level2_image_processing_pipeline fails on the first compare_asdf:

assert diff.identical, diff.report()

and the result is "oked". The next regression tests will likely continue to fail because the second compare_asdf:
assert diff.identical, diff.report()

is never reached and the second file is never produced for "okifying".

It would be beneficial to break up these long tests to avoid needing to okify several regression test runs (and to make the test output more informative).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant